Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Validate schema for SQLite connections #209

Merged
merged 9 commits into from
Dec 30, 2024
Merged

fix: Validate schema for SQLite connections #209

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
eaadd9a
fix: SQLite validate schema to stop panicking
peasee Dec 30, 2024
1318eec
fix: SQLite does not support dictionary
peasee Dec 30, 2024
48b743e
chore: Fix clippy
peasee Dec 30, 2024
7a7b71f
fix: SQLite does not support Map
peasee Dec 30, 2024
7ebcd47
chore: Clippy
peasee Dec 30, 2024
aced38c
fix: Optional dependencies
peasee Dec 30, 2024
6942d0b
chore: Clippy
peasee Dec 30, 2024
efb2793
chore: More clippy
peasee Dec 30, 2024
d175804
refactor: Move SchemaValidator implementations into DB modules
peasee Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: Clippy
  • Loading branch information
@peasee
peasee committed Dec 30, 2024
commit 6942d0b1e658136ed55c8e145256a3e4ce0ce3f7
2 changes: 2 additions & 0 deletions src/util/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ pub mod indexes;
pub mod ns_lookup;
pub mod on_conflict;
pub mod retriable_error;

#[cfg(any(feature = "sqlite", feature = "duckdb"))]
pub mod schema;
pub mod secrets;
pub mod test;
Expand Down
1 change: 0 additions & 1 deletion src/util/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ use std::sync::Arc;
use super::handle_invalid_type_error;
use crate::sql::db_connection_pool::dbconnection::Error as DbConnectionError;
use crate::InvalidTypeAction;
#[cfg(any(feature = "sqlite", feature = "duckdb"))]
use arrow_schema::{DataType, Field, SchemaBuilder};
use datafusion::arrow::datatypes::SchemaRef;

Expand Down
Loading