Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use Unparser for expr to sql #226

Merged
merged 6 commits into from
Jan 15, 2025
Merged

fix: Use Unparser for expr to sql #226

merged 6 commits into from
Jan 15, 2025
+72 −22

Conversation

peasee
Copy link
Collaborator

@peasee peasee commented Jan 15, 2025

  • Cherry picks a couple changes from main that include helpers to get dialect by engine, and filters_to_sql updates to use the DataFusion Unparser
  • Updates the sql() function of the SqlExec to use the DataFusion Unparser instead of to_sql_with_engine

@peasee peasee added the bug Something isn't working label Jan 15, 2025
@peasee peasee self-assigned this Jan 15, 2025
@peasee peasee requested review from phillipleblanc and sgrebnov and removed request for phillipleblanc January 15, 2025 05:13
phillipleblanc
phillipleblanc approved these changes Jan 15, 2025
View reviewed changes
src/sql/sql_provider_datafusion/expr.rs Outdated Show resolved Hide resolved
@peasee peasee merged commit f662b4a into spiceai Jan 15, 2025
3 checks passed
@peasee peasee deleted the fix/use-unparser-for-expr-to-sql branch January 15, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipleblanc phillipleblanc phillipleblanc approved these changes

@sgrebnov sgrebnov Awaiting requested review from sgrebnov

Assignees

@peasee peasee

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peasee @phillipleblanc