Skip to content
This repository has been archived by the owner on May 12, 2023. It is now read-only.

Check min and max length on all inputs and complain where appropriate. #281

Open
rossjones opened this issue Feb 7, 2017 · 7 comments
Open
Milestone

Comments

@rossjones
Copy link
Contributor

No description provided.

@gtdata
Copy link

gtdata commented Feb 14, 2017

As the content is trying to educate users about why they should stick to under 65 characters - is there a way we enforce this? Like Twitter do... @rossjones @maxf @BlancaTortajada

@maxf
Copy link
Contributor

maxf commented Feb 14, 2017

@gtdata: yes, it's possible. More specific questions:

  1. should we let the user save a draft with a title longer than 65 characters
  2. should we let the user publish a dataset with a title longer than 65 characters (or do we just warn them)?
  3. Same questions apply to description + what is the limit in characters?

@rossjones rossjones added this to the Alpha milestone Feb 17, 2017
@rossjones
Copy link
Contributor Author

The benefit of imposing restrictions here, is that when users edit existing datasets from the old site, we can enforce the new rules. So those datasets with very long titles we can force to be shortened.

@davidread
Copy link
Contributor

I think it should only be enforced on dataset creation. Occasionally we've had this situation in the past, where someone edits a dataset to change something and it blocks you until you fix something else unrelated. It's just caused confusion and support requests - "why is it complaining, what is wrong with my change?" not understanding it is a different in the error message, even with a pretty clear message and red box drawn around the field with the problem.

@maxf
Copy link
Contributor

maxf commented Feb 17, 2017

@davidread if it was enforced all the time, not just on creation, then people editing the dataset would only get error messages on what they just changed, no?

@davidread
Copy link
Contributor

Yes for ones created on the new system - that would work. It's the legacy datasets I'm concerned about.

@maxf
Copy link
Contributor

maxf commented Feb 17, 2017 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants