fix: minor pr comments

metadata-ingestion/docs/sources/looker/lookml_post.md

@@ -1,27 +1,50 @@
-#### Configuration Notes
+### Configuration Notes
 
-1. If a view contains a liquid template (e.g. `sql_table_name: {{ user_attributes['db']}}.kafka_streaming.events }}`, with `db=ANALYTICS_PROD`), then you will need to specify the values of those variables in the `liquid_variables` config as shown below:
+1. Handling Liquid Templates
+
+   If a view contains a liquid template, for example:
+
+   ```
+   sql_table_name: {{ user_attributes['db'] }}.kafka_streaming.events
+   ```
+
+   where `db=ANALYTICS_PROD`, you need to specify the values of those variables in the liquid_variables configuration as shown below:
 
    ```yml
    liquid_variables:
      user_attributes:
        db: ANALYTICS_PROD
    ```
 
-2. If a view contains a lookml constant (e.g., `sql_table_name: @{db}.kafka_streaming.events;`), its value is resolved in the following order:
+2. Resolving LookML Constants
+
+   If a view contains a LookML constant, for example:
+
+   ```
+   sql_table_name: @{db}.kafka_streaming.events;
+   ```
+
+   its value is resolved in the following order:
+
+   - First, checks the `lookml_constants` configuration.
+
+     ```yml
+     lookml_constants:
+       db: ANALYTICS_PROD
+     ```
+
+   - If not found, falls back to `manifest.lkml`:
+
+     ```yml
+     manifest.lkml
+       constant: db {
+           value: "ANALYTICS_PROD"
+       }
+     ```
 
-- **First, checks the `manifest.lkml` file** for the constant definition.
-  ```manifest.lkml
-    constant: db {
-        value: "ANALYTICS_PROD"
-    }
-  ```
-- **If not found, falls back to `config`**
+**Additional Notes**
 
-  ```yml
-  lookml_constants:
-    db: ANALYTICS_PROD
-  ```
+Although liquid variables and LookML constants can be used anywhere in LookML code, their values are currently resolved only for LookML views. This behavior is sufficient since DataHub LookML ingestion processes only views and their upstream dependencies.
 
 ### Multi-Project LookML (Advanced)
 

metadata-ingestion/src/datahub/ingestion/source/looker/looker_template_language.py

@@ -392,10 +392,10 @@
             if key in self.source_config.liquid_variables:
                 self.reporter.report_warning(
                     title="Misplaced lookml constant",
-                    message="Misplaced lookml constant, Use 'lookml_constants' instead of 'liquid_variables'.",
+                    message="Use 'lookml_constants' instead of 'liquid_variables'.",
                     context=f"Key {key}",
                 )
                 return f"@{{{key}}}"
 
             logger.warning(f"Constant '@{{{key}}}' not found in configuration.")
             return "NULL"

metadata-ingestion/tests/integration/lookml/test_lookml.py

@@ -1056,8 +1056,8 @@ def test_special_liquid_variables():
         ),
         # Case 10: Misplaced lookml constant
         (
-            {"sql_table_name": "@{liquid1}.@{constant1}"},
-            {"datahub_transformed_sql_table_name": "@{liquid1}.value1"},
+            {"sql_table_name": "@{constant1}.@{constant2}.@{constant4}"},
+            {"datahub_transformed_sql_table_name": "value1.value2.@{constant4}"},
             True,
         ),
     ],
@@ -1074,7 +1074,7 @@ def test_lookml_constant_transformer(view, expected_result, warning_expected):
         "constant2": "value2",
     }
     config.liquid_variables = {
-        "liquid1": "liquid_value1",
+        "constant4": "liquid_value1",
     }
 
     transformer = LookmlConstantTransformer(
@@ -1091,8 +1091,8 @@ def test_lookml_constant_transformer(view, expected_result, warning_expected):
     if warning_expected:
         report.report_warning.assert_called_once_with(
             title="Misplaced lookml constant",
-            message="Misplaced lookml constant, Use 'lookml_constants' instead of 'liquid_variables'.",
-            context="Key liquid1",
+            message="Use 'lookml_constants' instead of 'liquid_variables'.",
+            context="Key constant4",
         )