Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/fivetran): Add way to not add schema to the destination/source urn. #12314

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

treff7es
Copy link
Contributor

Kafka connector/Confluent cloud connector adds the connector name to the schema, which should not be part of the urn.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Kafka connector adds connector name to schema which should not be part of the urn.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 10, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../src/datahub/ingestion/source/fivetran/fivetran.py 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2226820) and HEAD (6d7c653). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (2226820) HEAD (6d7c653)
ingestion 4 2
Files with missing lines Coverage Δ
...on/src/datahub/ingestion/source/fivetran/config.py 82.07% <100.00%> (-14.12%) ⬇️
.../src/datahub/ingestion/source/fivetran/fivetran.py 33.92% <0.00%> (-60.62%) ⬇️

... and 201 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2226820...6d7c653. Read the comment docs.

Comment on lines 170 to 173
include_schema: bool = pydantic.Field(
default=True,
description="Include schema in the dataset URN. In some cases, the schema is not relevant to the dataset URN and Fivetran sets it to the connector name.",
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include_schema might be too generic and could lead to misunderstandings. WDYT about something like include_schema_in_urn instead?

I'm also a bit confused by the description: 'Include schema in the dataset URN' followed by 'Fivetran sets it to the connector name.' Is it referring to the dataset or the connector?

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jan 14, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jan 16, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jan 16, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants