feat: add version properties to mlmodel mapper #12343
Open
+95
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datahub-cyborg
bot
added
the
needs-review
| @@ -242,4 +242,48 @@ private static void mapEditableProperties(MLModel entity, DataMap dataMap) { | |||
| } | |||
| entity.setEditableProperties(editableProperties); | |||
| } | |||
|
|
|||
| private static void mapVersionProperties(MLModel entity, DataMap dataMap) { | |||
There was a problem hiding this comment.
Would expect a usage of this function above based on the aspect name, also + a test here
| """ | ||
| Represents properties about a versioned asset. | ||
| """ | ||
| type VersionProperties { |
There was a problem hiding this comment.
This might run into a merge conflict w/ Andrew's changes, will shoot you the link, not sure what the best approach to sync them would be.
There was a problem hiding this comment.
Do you need sortId for your logic? For now, I'm excluding it as I don't think the frontend should need it
datahub-cyborg
bot
added
pending-submitter-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist