Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): for python > 3.11 log a warning #12366

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

anshbansal
Copy link
Collaborator

The number of times I have had to tell people to use python 3.11 instead of python 3.12 and that solved the problem is too large. So putting this warning. Not throwing an exception because in many cases it can work.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
metadata-ingestion/src/datahub/entrypoints.py 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
metadata-ingestion/src/datahub/entrypoints.py 69.23% <50.00%> (-0.31%) ⬇️

... and 36 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2226820...e588e0a. Read the comment docs.

@anshbansal anshbansal merged commit 18701b7 into master Jan 16, 2025
177 of 207 checks passed
@anshbansal anshbansal deleted the ab-2025-jan-16-error-new-python branch January 16, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants