Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in probe definition #175

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Conversation

cwar
Copy link
Contributor

@cwar cwar commented Jul 24, 2024

Description

The documentation for the "Default Yet Configurable" startUpProbe contains a small typo where the u in startUp is not capitalized. This can cause some confusion when trying to incorporate this example config into a Druid configuration.


This PR has:

  • been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.
  • been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Key changed/added files in this PR
  • docs/features.md

The documentation for the "Default Yet Configurable" `startUpProbe` contains a small typo where the `u` in `startUp` is not capitalized. This can cause some confusion when trying to incorporate this example config into a Druid configuration.
@AdheipSingh AdheipSingh merged commit d6c81f1 into datainfrahq:master Sep 21, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants