Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mkdocs build issues, Refactor reader module and setup, Update docs and Dockerfile #5

Merged
merged 10 commits into from
Aug 31, 2024
Merged

Fix mkdocs build issues, Refactor reader module and setup, Update docs and Dockerfile #5

merged 10 commits into from
Aug 31, 2024

Conversation

MilagrosMarin
Copy link
Contributor

@MilagrosMarin MilagrosMarin commented May 17, 2024 •
edited
Loading

Changes:

  • Fix mkdocs build issues
  • Fix reader module imports by adding __init__.py
  • Refactor: Move KPMS installation to extras_require in setup for consistency with other Elements
  • Update markdown files in mkdocs
  • Update Dockerfile according to the proposed change

Tests:

  • Verify tutorial functionality in Codespaces post-changes
  • Ensure documentation builds correctly locally

@ttngu207
Copy link
Contributor

@MilagrosMarin please remove "Draft" if this PR is ready for review. Thanks

@MilagrosMarin MilagrosMarin changed the title Fix: docs Fix(docs) and update(setup,dockerfile) with KPMS installation as extras_require for consistency Aug 30, 2024
@MilagrosMarin
Copy link
Contributor Author

@ttngu207 I am currently working on adding a few more changes in this PR. I will remove "Draft" as soon as I finish testing them. Thanks!

@MilagrosMarin MilagrosMarin changed the title Fix(docs) and update(setup,dockerfile) with KPMS installation as extras_require for consistency Fix docs in the website and update setup&dockerfile with KPMS installation as extras_require for consistency Aug 30, 2024
@MilagrosMarin MilagrosMarin changed the title Fix docs in the website and update setup&dockerfile with KPMS installation as extras_require for consistency Fix mkdocs build issues, Refactor reader module, Update docs and Dockerfile Aug 30, 2024
@MilagrosMarin MilagrosMarin changed the title Fix mkdocs build issues, Refactor reader module, Update docs and Dockerfile Fix mkdocs build issues, Refactor reader module and setup, Update docs and Dockerfile Aug 30, 2024
@MilagrosMarin MilagrosMarin changed the title Fix mkdocs build issues, Refactor reader module and setup, Update docs and Dockerfile Fix mkdocs build issues, Refactor reader module and setup, Update docs and Dockerfile Aug 30, 2024
@MilagrosMarin MilagrosMarin marked this pull request as ready for review August 30, 2024 19:05
@MilagrosMarin MilagrosMarin requested a review from ttngu207 August 30, 2024 19:05
@ttngu207 ttngu207 merged commit 9864376 into datajoint:main Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttngu207 ttngu207 ttngu207 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MilagrosMarin @ttngu207