Initial implementation of manual ngram-based search in MongoDB #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
changed the title
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/mongo-fts-ngram
|
| Run status |
|
| Run duration | 06m 30s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
405
|
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
==========================================
+ Coverage 68.49% 68.92% +0.43%
==========================================
Files 62 62
Lines 3955 4026 +71
==========================================
+ Hits 2709 2775 +66
- Misses 1246 1251 +5
|
ml-evs
force-pushed
the
ml-evs/mongo-fts-ngram
branch
from
79b2bcc to
dbf241f
Compare
ml-evs
changed the title
ml-evs
force-pushed
the
ml-evs/mongo-fts-ngram
branch
from
63be944 to
d4969ae
Compare
|
I think this is ready for review now, though we should not make it the default (yet) until we can test scaling and quality of search results. |
ml-evs
force-pushed
the
ml-evs/mongo-fts-ngram
branch
from
d4969ae to
4fc2c6e
Compare
ml-evs
commented
Feb 7, 2025
| @@ -206,6 +206,7 @@ def create_app( | |||
| extension.init_app(app) | |||
|
|
|||
| pydatalab.mongo.create_default_indices() | |||
| pydatalab.mongo.create_ngram_item_index() | |||
There was a problem hiding this comment.
This should only be run on one of the API processes, or there should be a lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #679 -- MongoDB text indexes tokenize using whitespace and punctuation only. This PR investigates whether we can build a manual ngram index, so when searching for refcode
ABCDEF, you get results if you only ask forABC,BCDetc.This is done by making a separate collection called
item_ftsthat is used only for this kind of search, by storingimmutable_id,typeandngramsfor all items, with an index overngrams. Lookup is then done by ngrammifying the query string and doing array lookup and ordering by the number of matches.Will have to fiddle around to see:
Nis, and whether we need to do all N+1-grams up to a fixed range