Adjust Healthcheck for Podman and other improvements #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of Podman only seems to support checks running with `/bin/sh`
The current version of Podman only seems to support checks running with `/bin/sh`
The current version of Podman only seems to support checks running with `/bin/sh`
So that the result can be captured
So that the result can be captured
So that the result can be captured
Handle the case of empty response
The current version of Podman only seems to support checks running with `/bin/sh`
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #225 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 40 40
Lines 1542 1542
=======================================
Hits 1516 1516
Misses 26 26 ☔ View full report in Codecov by Sentry. |
candleindark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Podman currently doesn't support health check tests in list form. This PR expresses all health check tests in shell script form. Additionally, this PR add the following feature to health checks.