-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cron job #238
Merged
Merged
Update cron job #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `branches` fields is not JSONB type and conversion to `str` is no longer needed
…ith a partial implementation
This have type hint support in IDEs
Podman-compose currently doesn't support healthcheck tests specified as a list
To avoid issuing `chk_url` tasks that end up waiting
Using `repo_url_outdated_by_new_default_branch` fixture
…e_clone` fixture
Test the case that the clone of the dataset in the local cache is up-to-date
…c_by_new_default_branch`
To returns values of `repo_url_outdated_by_new_file` and `repo_url_off_sync_by_new_default_branch`
Against the case that the default branch at the remote has changed
Against the case that there is an update made available in the remote
Using `_modify_remote`
Using `_modify_remote`
Against the case of failure in updating the dataset URL representation in the database
FYI: A running instance of this version of Datalad-registry is available on Typhon |
This was referenced Oct 8, 2023
Merged
This was referenced Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to provide the implementation of a periodic updater that fulfills that intended goal for a periodic updater described in issue #112, and it closes both #112 and #134.
In support of the main goal, this PR also modifies existing Celery tasks,
process_dataset_url
andextract_ds_meta
, so that they appropriately lock theRepoUrl
record they modify to avoid potential race conditions and handle situations in which the given dataset URL id argument no longer identifies aRepoUrl
record in the database because of deletion before the execution of the tasks.TODOs