Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baby steps to make registry talk to catalog #278

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

yarikoptic
Copy link
Member

attn @jsheunis

in principle it should be startable/usable as we got to the "404" page from the metalad. Next steps were

  • translate metadata for catalog
  • pass metadata into catalog web UI so it could render it for us

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: Patch coverage is 22.58065% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 97.81%. Comparing base (0c05036) to head (7dd5b76).

Files Patch % Lines
datalad_registry/overview.py 22.58% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
- Coverage   98.73%   97.81%   -0.93%     
==========================================
  Files          53       53              
  Lines        2533     2561      +28     
==========================================
+ Hits         2501     2505       +4     
- Misses         32       56      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

note: was rebased and I visually copied needed items, hopefully I did not
miss any. I did not copy git describe since I do not see need in it now.
note: there was conflict during rebase in overview.html - I copied code
block in html for adding that "C" link out.
note: was conflict in docker-compose.dev.local.override.yml -- copied
invocation of datalad-catalog create
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant