Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dandi:files extractor #363

Merged
merged 11 commits into from
Aug 20, 2024

Conversation

candleindark
Copy link
Collaborator

This PR implements the dandi:files extractor. Additionally, it reorganizes the Docker compose files and dot env template files so that port of services at host can be changed easily. This ease of change of service ports at host facilitate running different instances of DL-Registry in the same host, allowing experimentation of different setup within a host.

@candleindark candleindark added the enhancement New feature or request label Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (5b1e274) to head (47074f2).
Report is 31 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   98.77%   98.81%   +0.04%     
==========================================
  Files          55       55              
  Lines        2605     2626      +21     
==========================================
+ Hits         2573     2595      +22     
+ Misses         32       31       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@candleindark candleindark marked this pull request as ready for review May 4, 2024 05:45
@candleindark
Copy link
Collaborator Author

candleindark commented May 4, 2024

@yarikoptic This PR is ready for merge. Upon your decision on whether to make the extracted metadata by dandi:files available on the production instance of DL-Registry on Typhon, we can merge this PR with

as is or commented.

datalad_registry/conf.py Outdated Show resolved Hide resolved
…tors

The extractor is not enabled for usual setups because of performance impact
@candleindark
Copy link
Collaborator Author

@yarikoptic I think we should merge this one if you are OK with the implementation. If you are concerned with the performance impact, we can run the registry with the dandi:files metadata extractor disabled (the default, see last comment). Beside implementing the dandi:files metadata extractor, this PR reorganizes the Docker compose files and dot env template files so that port of services at host can be changed easily. I want those changes available in the master branch.

These is a live instance of DL-Registry with the changes in this PR and the dandi:files metadata extractor enabled on Typhon. You can experience the changes of this PR though that instance.

@yarikoptic yarikoptic merged commit 005a2b7 into datalad:master Aug 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants