Replace temporary table with CTE in stats calculation #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result of `CTE` is reused in a query, so performance is increased
…ups` The result of `CTE` is reused in a query, so performance is increased
The result of `CTE` is reused in a query, so performance is increased
The result of `CTE` is reused in a query, so performance is increased
The result of `CTE` is reused in a query, so performance is increased
Creation of temporary tables are not allow in read-only db instances. We support the use of read-only db instances
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #370 +/- ##
==========================================
- Coverage 98.77% 98.76% -0.01%
==========================================
Files 55 55
Lines 2605 2599 -6
==========================================
- Hits 2573 2567 -6
Misses 32 32 ☔ View full report in Codecov by Sentry. |
Instead of executing a selectable in this function. Returning a scalar selectable call allow the result to be obtained in an enclosing query along with other subqueries
Instead of executing a selectable in a function. Returning a scalar selectable allow the stats to be obtained through execution of a single query containing many subqueries
It is no longer needed since temporary tables are not used anymore
|
Did you have a chance to compare performance - is there a notable difference? |
Yes, I compared the the performance of the two different setup. No, I couldn't perceive any difference in performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of temporary tables with CTEs (Common table expressions) in stats calculation of search results. The use of CTEs requires all subqueries to be executed in a combined query order to avoid repeated execution of a CTE. Consequently, some round trips to the DB server have been eliminated as well due to the use.
This PR closes #361.
Note: Changes in this PR have been applied to the Typhon and Falkor instances.
References: