Skip to content

Commit

Permalink
feat: BI-5792 Upgrade MySQL version to 8.0.40 (#729)
Browse files Browse the repository at this point in the history
* Upgrade MySQL version to 8.0.40

* Update MySQL connector to use DOUBLE type for dates (because of FLOAT overflow)

* Update MySQL dialect mentions to version 8.0.40 across tests and definitions

* Update MySQL version references to 8.0.40 in dialects and localization files

* Compiled licalization

* Fix backward compatibility issues

* Revert "Fix backward compatibility issues"

This reverts commit 47fcf83.

* Revert "Compiled licalization"

This reverts commit bddda72.

* Revert "Update MySQL version references to 8.0.40 in dialects and localization files"

This reverts commit e266bd0.

* Revert "Update MySQL dialect mentions to version 8.0.40 across tests and definitions"

This reverts commit 93c7fce.

---------

Co-authored-by: Denis Khamitov <[email protected]>
  • Loading branch information
khamitovdr and Denis Khamitov authored Nov 29, 2024
1 parent fb0ae83 commit 3c418f8
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -60,17 +60,17 @@
),
base.FuncFloatFromDate(
variants=[
V(D.MYSQL, lambda value: sa.cast(sa.func.UNIX_TIMESTAMP(value), sa_mysql.FLOAT)),
V(D.MYSQL, lambda value: sa.cast(sa.func.UNIX_TIMESTAMP(value), sa_mysql.DOUBLE)),
]
),
base.FuncFloatFromDatetime(
variants=[
V(D.MYSQL, lambda value: sa.cast(sa.func.UNIX_TIMESTAMP(value), sa_mysql.FLOAT)),
V(D.MYSQL, lambda value: sa.cast(sa.func.UNIX_TIMESTAMP(value), sa_mysql.DOUBLE)),
]
),
base.FuncFloatFromGenericDatetime(
variants=[
V(D.MYSQL, lambda value: sa.cast(sa.func.UNIX_TIMESTAMP(value), sa_mysql.FLOAT)),
V(D.MYSQL, lambda value: sa.cast(sa.func.UNIX_TIMESTAMP(value), sa_mysql.DOUBLE)),
]
),
# genericdatetime
Expand Down
4 changes: 2 additions & 2 deletions lib/dl_connector_mysql/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ services:
ports:
- "52000:3306"
db-mysql-8-0:
# image: "mysql:8.0.12"
# image: "mysql:8.0.40"
build:
context: docker-compose
dockerfile: Dockerfile.db-mysql-8.0.12
dockerfile: Dockerfile.db-mysql-8.0.40
environment:
MYSQL_ALLOW_EMPTY_PASSWORD: "1"
MYSQL_DATABASE: "test_data"
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# FROM mysql:8.0.40
FROM mysql:8.0.40@sha256:d58ac93387f644e4e040c636b8f50494e78e5afc27ca0a87348b2f577da2b7ff

COPY db-mysql/docker-entrypoint-initdb.d /docker-entrypoint-initdb.d

0 comments on commit 3c418f8

Please sign in to comment.