Skip to content

Commit

Permalink
comments cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
MCPN committed Nov 20, 2023
1 parent de6cf15 commit 73954e1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ def _datetrunc2_yql_impl(date_ctx, unit_ctx): # type: ignore
# today
base.FuncToday(
variants=[
V(D.YQL, sa.func.CurrentUtcDate), # https://yql.yandex-team.ru/docs/ydb/misc/not_yet_supported
V(D.YQL, sa.func.CurrentUtcDate), # https://ydb.tech/en/docs/yql/reference/syntax/not_yet_supported#now
]
),
# week
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,10 @@
),
# regexp_extract
# TODO: YQL
# https://yql.yandex-team.ru/docs/ydb/udf/list/hyperscan
# Problem:
# “По умолчанию все функции работают в однобайтовом режиме, но если
# регулярное выражение является валидной UTF-8 строкой, но не является
# валидной ASCII строкой, — автоматически включается режим UTF-8.”
# Problem: can't use higher-order functions yet.
# https://ydb.tech/en/docs/yql/reference/udf/list/hyperscan
# Problem: "By default, all functions work in the single-byte mode.
# However, if the regular expression is a valid UTF-8 string but is not a valid ASCII string,
# the UTF-8 mode is enabled automatically." However, we can't use higher-order functions yet.
# replace
base.FuncReplace(
variants=[
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
# /
base.BinaryDivInt(
variants=[
# See also: https://yql.yandex-team.ru/docs/ydb/?singlePage=true#_syntax_pragma_classicdivision
# See also: https://ydb.tech/en/docs/yql/reference/syntax/pragma#classicdivision
V(D.YQL, lambda x, y: sa.cast(x, sa.FLOAT) / y),
]
),
Expand Down

0 comments on commit 73954e1

Please sign in to comment.