Skip to content

Commit

Permalink
readonly type fix
Browse files Browse the repository at this point in the history
  • Loading branch information
juliarbkv committed Oct 16, 2024
1 parent c10e473 commit 8d1e54a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ class ClickHouseConnDTO(ClickHouseBaseDTO, DefaultSQLDTO): # noqa
# TODO CONSIDER: Is really optional
endpoint: Optional[str] = attr.ib(kw_only=True)
cluster_name: str = attr.ib(kw_only=True)
readonly: int = attr.ib(kw_only=True, default=None)
readonly: Optional[int] = attr.ib(kw_only=True, default=None)
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class BaseClickHouseConnTargetDTO(BaseSQLConnTargetDTO, BaseAiohttpConnTargetDTO
disable_value_processing: bool = attr.ib()
secure: bool = attr.ib(kw_only=True, default=False)
ssl_ca: Optional[str] = attr.ib(kw_only=True, default=None)
readonly: int = attr.ib(kw_only=True, default=None)
readonly: Optional[int] = attr.ib(kw_only=True, default=None)

# TODO remove in the next release to avoid compatibility issues
insert_quorum: Optional[int] = attr.ib(kw_only=True, default=None)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class DataModel(ClassicConnectionSQL.DataModel):
cluster_name: Optional[str] = attr.ib(default=None)
max_execution_time: Optional[int] = attr.ib(default=None)
ssl_ca: Optional[str] = attr.ib(kw_only=True, default=None)
readonly: int = attr.ib(kw_only=True, default=None)
readonly: Optional[int] = attr.ib(kw_only=True, default=None)

def get_conn_dto(self) -> ClickHouseConnDTO:
return ClickHouseConnDTO(
Expand Down

0 comments on commit 8d1e54a

Please sign in to comment.