Enable YDB connector #160
Merged
Enable YDB connector #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vallbull
force-pushed
the
turn_on_ydb_os
branch
from
0f135e7 to
fdb9994
Compare
MCPN
reviewed
Dec 21, 2023
MCPN
reviewed
Dec 21, 2023
| DEFAULT_HOST_VALUE: Optional[str] = s_attrib("DEFAULT_HOST_VALUE", missing=None) # type: ignore | ||
|
|
||
|
|
||
| class ConnectorsDataYDBBase(ConnectorsDataBase): | ||
| MANAGED_OAUTH_ROW: ClassVar[Optional[bool]] = True |
There was a problem hiding this comment.
Why not add DEFAULT_HOST_VALUE here too?
vallbull
force-pushed
the
turn_on_ydb_os
branch
from
f017375 to
6cea607
Compare
KonstantAnxiety
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.