Ya docs handler #28
Merged
Ya docs handler #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vallbull
force-pushed
the
ya_docs_handler
branch
from
9241ada to
b20c44a
Compare
vallbull
force-pushed
the
ya_docs_handler
branch
from
a67d12d to
f82bc38
Compare
Comment on lines
+29
to
+30
| if data["private_path"] is None or data["oauth_token"] is None: | ||
| raise ma.ValidationError("Both path and token must be provided for private files") |
There was a problem hiding this comment.
Well, not exactly
If we are working with an existing connection, we won't receive the token and we'll have to use the one saved inside the connection – it is only sent to the backend when the connection is created or the token is updated, we never give secrets back in our responses
(This can be fixed later as a different PR, when we have the pipeline going with actual connections)
KonstantAnxiety
requested changes
Nov 2, 2023
lib/dl_file_uploader_api_lib/dl_file_uploader_api_lib/views/files.py
Outdated
Show resolved
Hide resolved
lib/dl_file_uploader_api_lib/dl_file_uploader_api_lib/views/files.py
Outdated
Show resolved
Hide resolved
lib/dl_file_uploader_worker_lib/dl_file_uploader_worker_lib/tasks/download_yadocs.py
Outdated
Show resolved
Hide resolved
lib/dl_file_uploader_worker_lib/dl_file_uploader_worker_lib/tasks/excel.py
Show resolved
Hide resolved
…sks/download_yadocs.py Co-authored-by: KonstantAnxiety <[email protected]>
|
|
||
| task_processor = self.dl_request.get_task_processor() | ||
| await task_processor.schedule(DownloadYaDocsTask(file_id=df.id)) | ||
| LOGGER.info(f"Scheduled DownloadGSheetTask for file_id {df.id}") |
There was a problem hiding this comment.
Scheduled DownloadGSheetTask DownloadYaDocsTask
| @@ -88,6 +89,10 @@ async def run(self) -> TaskResult: | |||
| return Success() | |||
|
|
|||
| dfile.filename = spreadsheet_meta["name"] | |||
| xlsx_suffix = ".xlsx" | |||
| if not dfile.filename.endswith(xlsx_suffix): | |||
| raise exc.UnsupportedDocument | |||
There was a problem hiding this comment.
Let's save the exact reason the file was rejected in the error details (in future PRs)
Something like this
raise exc.UnsupportedDocument(details={"reason": f"Supported file extensions are: '.xlsx'. Got {dfile.filename}"})
KonstantAnxiety
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.