Add an option to skip non-existent files in diff-related dl-git commands #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altvod
suggested changes
Oct 25, 2023
| result.add(str(base_path / diff_item.a_path)) | ||
| if diff_item.b_path: | ||
| result.add(str(base_path / diff_item.b_path)) | ||
| for diff_path in (diff_item.a_path, diff_item.b_path): |
There was a problem hiding this comment.
Better to do this in a separate cycle - first we collect and deduplicate all the paths, and then we apply filters.
It would be a bit more flexible and would save some CPU time if there is a lot of commits for the same paths.
KonstantAnxiety
force-pushed
the
gitmgr-diff-wo-deleted
branch
from
6c7ff0b to
5161040
Compare
KonstantAnxiety
force-pushed
the
gitmgr-diff-wo-deleted
branch
from
5161040 to
ab308f3
Compare
altvod
suggested changes
Oct 25, 2023
| result: set[str] = set() | ||
| for base_path, diff_item in diff_iterable: | ||
| if diff_item.a_path: | ||
| result.add(str(base_path / diff_item.a_path)) | ||
| if diff_item.b_path: | ||
| result.add(str(base_path / diff_item.b_path)) | ||
|
|
||
| if without_deleted: | ||
| result = {path for path in result if os.path.exists(path)} |
There was a problem hiding this comment.
You need to check for existence via the git file tree for the head state because it will not necessarily be the same as the real FS (i.e. the current repository state might (and probably will) be different from head).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.