Add mysql connector #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 24, 2023 23:24
asnytin
reviewed
Oct 25, 2023
lib/dl_formula/pyproject.toml
Outdated
Comment on lines
26
to
27
| mysqlclient = ">=1.4.6" | ||
| pymysql = "==1.1.0" | ||
| oracledb = ">=1.3.1" |
There was a problem hiding this comment.
we shouldn't need these deps in a base dl_formula package
nothing related to specific connectors (pg, ch, oracle...)
There was a problem hiding this comment.
Seems that you're right. Will remove this dep and update lock file.
asnytin
reviewed
Oct 25, 2023
lib/dl_connector_mysql/Makefile
Outdated
asnytin
previously approved these changes
Oct 25, 2023
asnytin
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Init pull request for mysql connector and mysql sqlalchemy packages