Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed MySQL connector query compiler merge #62

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Fixed MySQL connector query compiler merge #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/dl_connector_mysql/dl_connector_mysql/core/connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
MySQLSubselectDataSource,
)
from dl_connector_mysql.core.data_source_migration import MySQLDataSourceMigrator
from dl_connector_mysql.core.query_compiler import MySQLQueryCompiler
from dl_connector_mysql.core.sa_types import SQLALCHEMY_MYSQL_TYPES
from dl_connector_mysql.core.storage_schemas.connection import ConnectionMySQLDataStorageSchema
from dl_connector_mysql.core.type_transformer import MySQLTypeTransformer
Expand Down Expand Up @@ -60,3 +61,4 @@ class MySQLCoreConnector(CoreConnector):
)
rqe_adapter_classes = frozenset({MySQLAdapter, AsyncMySQLAdapter})
sa_types = SQLALCHEMY_MYSQL_TYPES
compiler_cls = MySQLQueryCompiler
3 changes: 1 addition & 2 deletions lib/dl_connector_mysql/dl_connector_mysql/core/data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ class MySQLDataSourceMixin(BaseSQLDataSource):
)

conn_type = CONNECTION_TYPE_MYSQL
compiler_cls = MySQLQueryCompiler

@classmethod
def is_compatible_with_type(cls, source_type: DataSourceType) -> bool:
Expand All @@ -46,8 +47,6 @@ def is_compatible_with_type(cls, source_type: DataSourceType) -> bool:
class MySQLDataSource(MySQLDataSourceMixin, StandardSQLDataSource):
"""MySQL table"""

compiler_cls = MySQLQueryCompiler


class MySQLSubselectDataSource(MySQLDataSourceMixin, SubselectDataSource):
"""MySQL table from a subquery"""
Loading