refactor: use instantiation

[warcooft]

See codeigniter4/CodeIgniter4#9052 (comment)

Summary by CodeRabbit

• New Features

  • Improved instance management for the OAuth functionality, ensuring a fresh instance is used each time the allOAuth method is called.
  • Enhanced clarity in the code by updating substring checks to use str_contains, improving readability.

• Bug Fixes

  • Enhanced reliability of the autoloading mechanism by preventing potential conflicts with pre-configured instances.

[coderabbitai]

Walkthrough

The recent modifications in the codebase enhance the functionality and clarity of the ShieldOAuth and NewShieldOauthGenerator classes. The allOAuth method now creates a fresh instance of Autoload each time it is called, promoting better isolation. Additionally, the run method in the NewShieldOauthGenerator class replaces strpos with the more expressive str_contains, improving readability and aligning with modern PHP practices.

Changes

Files	Change Summary
src/Libraries/Basic/ShieldOAuth.php	In allOAuth, a new Autoload instance is created using new Autoload() instead of fetching a pre-configured instance, ensuring fresh instance usage.
src/Commands/Generators/NewShieldOauthGenerator.php	In run, strpos is replaced with str_contains to check for 'OAuth' in $class, enhancing readability while maintaining the same control flow.

Poem

In fields of code where bunnies play,
A change was made to brighten the day.
New instances hop, no strings attached,
Autoloads spring forth, perfectly matched.
With every call, fresh paths we find,
A leap towards clarity, oh so kind! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 970262b and 581987f.

Files selected for processing (1)

• src/Libraries/Basic/ShieldOAuth.php (1 hunks)

Additional comments not posted (5)

src/Libraries/Basic/ShieldOAuth.php (5)

Line range hint 18-28:
LGTM!

The setOAuth function correctly creates an instance of an OAuth class based on the service name. No issues identified.

---

Line range hint 78-82:
LGTM!

The otherOAuth function correctly returns an array of custom OAuth services. No issues identified.

---

Line range hint 90-120:
LGTM!

The makeOAuthButton function correctly creates OAuth buttons and includes a dropdown for custom OAuth services. No issues identified.

---

Line range hint 3-16:
LGTM!

The class-level docstrings and imports are correct and necessary for the functionality. No issues identified.

---

60-60: Verify the impact of directly instantiating Autoload.

The change to instantiate a new Autoload object directly ensures a fresh instance but might bypass any specific settings or state previously configured. Verify that this change does not negatively impact the overall functionality.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 581987f and 098530f.

Files selected for processing (1)

• src/Commands/Generators/NewShieldOauthGenerator.php (1 hunks)

Additional comments not posted (1)

src/Commands/Generators/NewShieldOauthGenerator.php (1)

106-107: LGTM! Modernized the code with str_contains.

The replacement of strpos with str_contains improves readability and aligns with modern PHP practices.

[datamweb]

@coderabbitai Explain to the contributor that we currently support php version 7.4 so the use of command str_contains is not allowed.

Also, explain to the contributor that they should not use the merge command for a regular history of commits.

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

@warcooft:

Please note that our project currently supports PHP version 7.4. Therefore, the use of the str_contains function is not allowed, as it was introduced in PHP 8.0. You may need to revert to using strpos for compatibility.

Additionally, to maintain a clean and regular commit history, please avoid using the merge command for routine commits. Instead, consider using rebase or squash methods to keep the history linear and easier to follow.

Thank you for your understanding and cooperation.