refactor: use instantiation

[warcooft]

Description

See codeigniter4/CodeIgniter4#9052

Summary by CodeRabbit

• Bug Fixes

  • Improved the instantiation of the Autoload class to ensure a fresh instance is created with each call, enhancing reliability in dependency management.

• Enhancements

  • Added comments to improve static analysis clarity in the NewShieldOauthGenerator, ensuring code quality without altering existing functionality.
  • Updated code style configuration to prevent automatic modernization of the strpos function, allowing for consistent usage patterns.

[coderabbitai]

Walkthrough

The recent updates enhance the allOAuth method in the ShieldOAuth class by directly instantiating a new Autoload object, shifting from a pre-configured instance. This change could impact dependency management depending on the state of Autoload during calls. Additionally, adjustments for static analysis and coding standards have been implemented, promoting a smoother development experience.

Changes

Files	Change Summary
.../Basic/ShieldOAuth.php	Updated allOAuth method to instantiate Autoload using new Autoload() instead of retrieving it via config(Autoload::class), altering instance management and control flow.
.../Generators/NewShieldOauthGenerator.php	Added a comment to the run method to instruct PHPStan to ignore the following line, clarifying static analysis without affecting the logic.
.php-cs-fixer.dist.php	Added 'modernize_strpos' => false to the $overrides array, preventing automatic modernization of strpos usage in the codebase.

Poem

🐇 In the code where changes bloom,
A new instance brings fresh room.
Autoload hops in with glee,
Each call anew, just wait and see!
Onward we code, let logic flow,
With every tweak, our skills will grow! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 970262b and fd4a3ff.

Files selected for processing (1)

• src/Libraries/Basic/ShieldOAuth.php (1 hunks)

Additional comments not posted (1)

src/Libraries/Basic/ShieldOAuth.php (1)

60-60: Verify the impact of the new instantiation approach.

The new code creates a fresh instance of Autoload each time the method is called. Ensure this change does not negatively impact the application's performance or behavior, especially if Autoload maintains state or configuration.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fd4a3ff and 10a931e.

Files selected for processing (1)

• src/Commands/Generators/NewShieldOauthGenerator.php (1 hunks)

Files skipped from review due to trivial changes (1)

• src/Commands/Generators/NewShieldOauthGenerator.php

[datamweb]

@warcooft thank you!

All commits must be signed.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 10a931e and 2eaee20.

Files selected for processing (1)

• .php-cs-fixer.dist.php (1 hunks)

Additional comments not posted (1)

.php-cs-fixer.dist.php (1)

33-33: Addition of modernize_strpos configuration option.

The new configuration option modernize_strpos is added to the $overrides array and set to false. This change disables the functionality related to modernizing the use of strpos, providing more granular control over the code style rules applied during the fixing process.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2eaee20 and 60a85ad.

Files selected for processing (1)

• .php-cs-fixer.dist.php (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• .php-cs-fixer.dist.php

[datamweb]

@warcooft thanks!