Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve mandatory email address from Github #127

Closed
wants to merge 5 commits into from

Commits on Jul 20, 2024

  1. Update GithubOAuth.php

    Retrieve the user's email addresses regardless if their status is set public or not
    Zoly authored Jul 20, 2024
    Configuration menu
    Copy the full SHA
    668118a View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1 from Zoly/Zoly-patch-2

    Update GithubOAuth.php
    Zoly authored Jul 20, 2024
    Configuration menu
    Copy the full SHA
    a347985 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2024

  1. Configuration menu
    Copy the full SHA
    070b993 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Retrieve mandatory email address from Github

    The /user API returns only the data the user explicitly set as public and null for those he didn't. 
    
    If the user did not set the email address public (me for example), the email address being mandatory for the process, the authentication fails returning an error message.
    
    By using the /user/emails API in conjunction, it is possible to retrieve all the email addresses the user set in Github, regardless if they are set public or not, and select one of those (ex: primary one), for the login process to complete successfully.
    Zoly authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    646980d View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2 from Zoly/Retrieve-mandatory-email-address-from…

    …-Github
    
    Retrieve mandatory email address from Github
    Zoly authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    e7f30a4 View commit details
    Browse the repository at this point in the history