Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Returns the user's email if the account is not found. #133

Merged
merged 3 commits into from
Jul 28, 2024

Conversation

warcooft
Copy link
Contributor

@warcooft warcooft commented Jul 28, 2024

Supersedes #132

Summary by CodeRabbit

  • New Features

    • Updated error messages for account-related issues during OAuth login to provide specific email information, enhancing user feedback and experience.
  • Localization

    • Improved clarity of error messages in English, French, Persian, and Indonesian to specify that no account is registered with the provided email, aiding user understanding.

Copy link

coderabbitai bot commented Jul 28, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The recent changes improve the error handling in the OAuth authentication process by providing more personalized and informative error messages. When a user account is not found, the message now includes the user's email address, enhancing clarity and user experience. These adjustments are reflected across multiple language localization files, ensuring that users receive precise feedback tailored to their language preferences.

Changes

Files Change Summary
src/Controllers/OAuthController.php Modified error handling in callBack method to include user email in the account not found message.
src/Language/en/ShieldOAuthLang.php, src/Language/fa/ShieldOAuthLang.php, src/Language/fr/ShieldOAuthLang.php, src/Language/id/ShieldOAuthLang.php Updated account_not_found messages to clarify that no account is registered with the provided email, enhancing user guidance.

Poem

🐇 In fields of code, a change so bright,
Errors now whisper, "Your email's in sight!"
With every login, a clearer way,
“No account found,” the message now says.
Hop along, dear user, with joy in your heart,
For troubleshooting now plays a kinder part! ✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between afdd769 and bf10b18.

Files selected for processing (5)
  • src/Controllers/OAuthController.php (1 hunks)
  • src/Language/en/ShieldOAuthLang.php (1 hunks)
  • src/Language/fa/ShieldOAuthLang.php (1 hunks)
  • src/Language/fr/ShieldOAuthLang.php (1 hunks)
  • src/Language/id/ShieldOAuthLang.php (1 hunks)
Files skipped from review due to trivial changes (2)
  • src/Language/en/ShieldOAuthLang.php
  • src/Language/fa/ShieldOAuthLang.php
Additional context used
GitHub Check: PHP 8.1 Static Analysis
src/Controllers/OAuthController.php

[failure] 88-88:
Syntax error, unexpected ')', expecting ';' on line 88

GitHub Check: PHP 8.0 Static Analysis
src/Controllers/OAuthController.php

[failure] 88-88:
Syntax error, unexpected ')', expecting ';' on line 88

GitHub Check: PHP 7.4 Static Analysis
src/Controllers/OAuthController.php

[failure] 88-88:
Syntax error, unexpected ')', expecting ';' on line 88

Additional comments not posted (1)
src/Language/id/ShieldOAuthLang.php (1)

21-21: Enhancement of error message clarity.

The updated error message provides more context by including the email address, improving user experience.

src/Language/fr/ShieldOAuthLang.php Outdated Show resolved Hide resolved
src/Controllers/OAuthController.php Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bf10b18 and 56c68dd.

Files selected for processing (1)
  • src/Controllers/OAuthController.php (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/Controllers/OAuthController.php

@datamweb datamweb added the enhancement New feature or request label Jul 28, 2024
Copy link
Owner

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@warcooft thank you!

@datamweb datamweb merged commit 1f36be9 into datamweb:develop Jul 28, 2024
11 checks passed
@warcooft warcooft deleted the feat-2 branch July 28, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants