-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Returns the user's email if the account is not found. #133
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe recent changes improve the error handling in the OAuth authentication process by providing more personalized and informative error messages. When a user account is not found, the message now includes the user's email address, enhancing clarity and user experience. These adjustments are reflected across multiple language localization files, ensuring that users receive precise feedback tailored to their language preferences. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- src/Controllers/OAuthController.php (1 hunks)
- src/Language/en/ShieldOAuthLang.php (1 hunks)
- src/Language/fa/ShieldOAuthLang.php (1 hunks)
- src/Language/fr/ShieldOAuthLang.php (1 hunks)
- src/Language/id/ShieldOAuthLang.php (1 hunks)
Files skipped from review due to trivial changes (2)
- src/Language/en/ShieldOAuthLang.php
- src/Language/fa/ShieldOAuthLang.php
Additional context used
GitHub Check: PHP 8.1 Static Analysis
src/Controllers/OAuthController.php
[failure] 88-88:
Syntax error, unexpected ')', expecting ';' on line 88
GitHub Check: PHP 8.0 Static Analysis
src/Controllers/OAuthController.php
[failure] 88-88:
Syntax error, unexpected ')', expecting ';' on line 88
GitHub Check: PHP 7.4 Static Analysis
src/Controllers/OAuthController.php
[failure] 88-88:
Syntax error, unexpected ')', expecting ';' on line 88
Additional comments not posted (1)
src/Language/id/ShieldOAuthLang.php (1)
21-21
: Enhancement of error message clarity.The updated error message provides more context by including the email address, improving user experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/Controllers/OAuthController.php (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- src/Controllers/OAuthController.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@warcooft thank you!
Supersedes #132
Summary by CodeRabbit
New Features
Localization