-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom header validation #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* chore(main): release 1.0.0 * docs: add contributors
robe-rt
reviewed
Nov 15, 2024
...mpatibility-checker/src/main/java/net/syntio/compatibility/controller/CheckerController.java
Show resolved
Hide resolved
robe-rt
reviewed
Nov 15, 2024
robe-rt
reviewed
Nov 15, 2024
robe-rt
reviewed
Nov 15, 2024
robe-rt
reviewed
Nov 15, 2024
robe-rt
previously approved these changes
Nov 15, 2024
robe-rt
previously approved these changes
Nov 19, 2024
robe-rt
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new feature which allows validation of fields in the header. Header validation can be turned on on the Validator level by setting a specific variable in the config map, which requires each message to contain header schema ID and version. Otherwise, the validation fails because of missing required headers. Additionally, the header validation can be turned on/off on the single message level; it can be set by specifying the headerValidation flag to true/false. If headerValidation is set in message's header, Validator level flag is ignored.
Type of change
Related Issue
Checklist
How Has This Been Tested?
This has been tested by setting the Validator' header validation flag to true and false. A set of messages was sent; these messages contained the same payload, but different headers. The cases that were tested are the following:
All headers that provided sufficient info were validated correctly and in case of an error, all error messages and error codes were displayed correctly.