Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new features #49

Merged
merged 4 commits into from
Jan 13, 2025
Merged

feat: new features #49

merged 4 commits into from
Jan 13, 2025

Conversation

Simun17
Copy link
Collaborator

@Simun17 Simun17 commented Jan 13, 2025

Description

Made the following changes:

  • fixed bug where omitting the format field in schema registration didn't result in error
  • changed the message when sending GET request to the empty Registry
  • added config for default header schema id and header schema version
  • added error reason to message's header when using Avro format

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (improving code structure without changing external behavior)
  • Other (please explain):

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My code is well documented
  • I have read and understood the contribution guidelines

How Has This Been Tested?

Each feature was tested (more details in the PRs to the develop branch)

@Simun17 Simun17 requested a review from robe-rt January 13, 2025 14:08
Copy link
Contributor

@robe-rt robe-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@Simun17 Simun17 merged commit 2320978 into main Jan 13, 2025
21 checks passed
@Simun17 Simun17 mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants