removal of useless comment #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#226) Co-authored-by: MilanMajchrák <[email protected]>
* Added a new empty notice step. * Configured collection with specific step. * Fixed checkstyle issues. --------- Co-authored-by: MilanMajchrák <[email protected]>
* Changed input type to `name` it divides the author one input field to two input fields. * Created input type `clarin-name` * Working on fixing the MetadataValueRestRepository - it returns a lot of suggestions if the Item contains searched value * Created test to check if the error is fixed. --------- Co-authored-by: MilanMajchrák <[email protected]>
…asharev2 crosswalk. (#223) * Added missing metasharev2 crosswalk into xoai.xml - without it, this crosswalk would never be used. * Added a new metadata formats for the `metashare2.xsl` crosswalk * Working on separator and trying to fix metashare crosswalk * Created scripts for fast updating the crosswalks without rebuilding and installing the dspace project. * Added fast building script for oai-pmh package * Added fast building script for dspace-api package * str:split function replaced by the tokenize function. * Fixed creating NodeList * Refactoring * Added script for updating the configuration files * Refactoring and fixed checkstyle violations * `registry.metadata.load = metashare-schema.xml` property cannot be added in the `clarin-dspace.cfg` because then some Unit tests are failing.. --------- Co-authored-by: MilanMajchrák <[email protected]>
* Added a new searching endpoint into ClarinLicenseRestRepository to find Clarin License by substring of it's name * Fixed checkstyle issue --------- Co-authored-by: MilanMajchrák <[email protected]>
) * Added withdraw and discoverable option into search defaultFilterQueries into discovery.xml * Copied fix code from the vanilla DSpace. * Added a new itemtype search filter. --------- Co-authored-by: MilanMajchrák <[email protected]>
Co-authored-by: MilanMajchrák <[email protected]>
* Hide `local.submission.note` metadata field form the full item page. * Updated ItemConverter and MetadataExposureService to show hidden metadata values for the submitter. Also fixed showing all licenses for every user, not only for the admin. * Submitter cannot see metadata fields which could see only admin. * Updated the integration test --------- Co-authored-by: MilanMajchrák <[email protected]>
* export table data as json * controller for group import * upgrade values type in database * alter table * controller for group2group import * controller for group2eperson * Removed varchar limitations (#218) Co-authored-by: MilanMajchrák <[email protected]> * create new cntroller for item and service for workspaceitem * changed Controller from ItemRest to WorkspaceRest * added test * fix error in controller * create workflowitem from workspaceitem * problem with adding submitter and creating workflowitem * import workflowitem and item * fix incorrect class in log' * 'reate bitstream without file, error with protected consturctor * test for create bundle for existing file * missing committed xml file * fix errors for bitstream validation * correction of the test errors * added primary bitstream to bitstream * test for import items * fix item tests - inArchive * fix import item tests * correction of found errors * controller for import eperson and user_registration * import logo of collection and community * modified bitstream import and added most_recent_checksum import * fix specifically date format * added test for import logo * new builder for bitstream without item and bundle, fix test errors * checkstyle and comments * fix tests * checkstyle and fix test * fix failed test * Fixed review issues. * 74-BE license definition missing attribute values * Fixed review requests. * Removed unnecessary files --------- Co-authored-by: milanmajchrak <[email protected]> Co-authored-by: MilanMajchrák <[email protected]>
* Updated README-dtq.md * Updated README-dtq.md with not imported and missing tables --------- Co-authored-by: MilanMajchrák <[email protected]>
* Added ClarinItemTypeFilterMatcher * Fixed IT * Added a new Browse matchers for updated browse searching. * Fixed removed tests * Fixed removed tests * Fixed removed tests * Fixed removed tests --------- Co-authored-by: MilanMajchrák <[email protected]>
* replace readAllBytes * fix test errors
* The user is redireced to the FE after wrong shibboleth authentication. * Changed redirect URLs * Fixed checkstyle issues * Copied ShibbolethFilterIT into ClarinShibbolethFilterIT because the tests did must be updated.
* firstname and lastname is not required for proper Shibboleth login. * Fixed IT to be failed if code is wrong
* License label icon can be null * user rest repository for license import * Fixed checkstyle issues * Fixed failing IT --------- Co-authored-by: milanmajchrak <[email protected]>
* Every bitstream is deleted after updating it. If the sequenceId is null, use default value. * added logs and fixed error message * Fixed checkstyle issues * Added some logs. --------- Co-authored-by: Michaela Paurikova <[email protected]>
* create method and test * test runs * condition of membership
* add welcome_info and can_edit_submission_metadata * added missing attributes to the database * errors from review
* remove validation control for deleted bitstream * added log * fix review comments
* added mvn argument fail-at-end * see mvn version * see maven version * -fae * final version of build.yml
* create handle without dspace object * new controller for import handle without dspace object * create handle for workspaceitem * using of existing handle if it exists (#316) * checkstyle * fix failed test * added whitespace after for * review * removed authorization for handle creation * remove unneeded import * checkstyle
* Initial commit * Remove the error when the ClarinLicense doesn't require any additional user metadata and the file cannot be downloaded because the user didn't fill in any user metadata. * The user cannot download the item with ClarinLicense that doesn't require user metadata, but controller methods required this information.
* 116-be/deleted-bitstreams-cannot-be-imported (#291) * Every bitstream is deleted after updating it. If the sequenceId is null, use default value. * added logs and fixed error message * Fixed checkstyle issues * Added some logs. --------- Co-authored-by: Michaela Paurikova <[email protected]> * 76-BE/import-user-metadata (#294) * new controller for user metadata import * import user metadata works based on created tests * remove error from python import * checkstyle * 76-BE/import-user-metadata-with-fixed-bitstream (#307) * new controller for user metadata import * import user metadata works based on created tests * remove error from python import * checkstyle * fix import user_metadata * fix mishmash with eperson_id and user_registration_id * create user registration and eperson separatelly, checkstyle * edited import user metadata * checkstyle --------- Co-authored-by: Michaela Paurikova <[email protected]> Co-authored-by: Paurikova2 <[email protected]>
* Removed not defined search options. * Updated IT according to a cfg updates.
* 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: DSpace#8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR DSpace#8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a (DSpace#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * DSpace#8629: Make sure temporary worfklow groups of reviewers get deleted * DSpace#8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * DSpace#8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <[email protected]> Co-authored-by: milanmajchrak <[email protected]> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests * Migrate to 7.5 (#274) * 97298: Self-register - test fixes * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: DSpace#8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR DSpace#8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a (DSpace#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * DSpace#8629: Make sure temporary worfklow groups of reviewers get deleted * DSpace#8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * DSpace#8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <[email protected]> Co-authored-by: milanmajchrak <[email protected]> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <[email protected]> Co-authored-by: Giuseppe Digilio <[email protected]> Co-authored-by: corrado lombardi <[email protected]> Co-authored-by: Mohamed Saber Eskander <[email protected]> Co-authored-by: Koen Pauwels <[email protected]> Co-authored-by: Jens Vannerum <[email protected]> Co-authored-by: jensroets <[email protected]> Co-authored-by: Yana De Pauw <[email protected]> Co-authored-by: Tim Donohue <[email protected]> Co-authored-by: jensvannerum <[email protected]> Co-authored-by: Mykhaylo <[email protected]> Co-authored-by: Francesco Pio Scognamiglio <[email protected]> Co-authored-by: Nona Luypaert <[email protected]> Co-authored-by: Toni Prieto <[email protected]> Co-authored-by: Alexandre Vryghem <[email protected]> Co-authored-by: Kim Shepherd <[email protected]> Co-authored-by: Pascal-Nicolas Becker <[email protected]> Co-authored-by: Agustina Martinez <[email protected]> Co-authored-by: Raf Ponsaerts <[email protected]> Co-authored-by: Andrea Bollini <[email protected]> Co-authored-by: MajoBerger <[email protected]> Co-authored-by: MajoBerger <[email protected]> * Copied fix from 303 * Copied fix from 302, 319, 314 * Copied fix from 331 * Copied fix from 295 * Copied fix from 337, 339 * Removed ClarinLicenseImportRestController.java according to 273 * Eperson.hasPasswordSet was missing and one checkstyle violation as occurred. * Docker image should be generated. * Full BE customization for TUL (#329) * define citace pro in the config file * rename the config and add it into the default res.properties.exposed * configure the gg analytics * add email config propertyy for the contact page * add the email for lr.help.email * remove redundant email --------- Co-authored-by: HuynhKhoa1601 <[email protected]> Co-authored-by: HuynhKhoa1601 <[email protected]> * Temp file * Migrate to 7.5 (#343) * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: DSpace#8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR DSpace#8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a (DSpace#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * DSpace#8629: Make sure temporary worfklow groups of reviewers get deleted * DSpace#8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * DSpace#8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <[email protected]> Co-authored-by: milanmajchrak <[email protected]> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <[email protected]> Co-authored-by: Giuseppe Digilio <[email protected]> Co-authored-by: corrado lombardi <[email protected]> Co-authored-by: Mohamed Saber Eskander <[email protected]> Co-authored-by: Koen Pauwels <[email protected]> Co-authored-by: Jens Vannerum <[email protected]> Co-authored-by: jensroets <[email protected]> Co-authored-by: Yana De Pauw <[email protected]> Co-authored-by: Tim Donohue <[email protected]> Co-authored-by: jensvannerum <[email protected]> Co-authored-by: Mykhaylo <[email protected]> Co-authored-by: Francesco Pio Scognamiglio <[email protected]> Co-authored-by: Nona Luypaert <[email protected]> Co-authored-by: Toni Prieto <[email protected]> Co-authored-by: Alexandre Vryghem <[email protected]> Co-authored-by: Kim Shepherd <[email protected]> Co-authored-by: Pascal-Nicolas Becker <[email protected]> Co-authored-by: Agustina Martinez <[email protected]> Co-authored-by: Raf Ponsaerts <[email protected]> Co-authored-by: Andrea Bollini <[email protected]> Co-authored-by: MajoBerger <[email protected]> Co-authored-by: MajoBerger <[email protected]> * Removed unused class * Updated docker.yml * Updated cfg (#348) * Fixed from port 4000 to 8080 (#350) * add redeploy to dev-5 -> curl call to deploy action * add redeploy to dev-5 -> curl call to deploy action * correct redeploy branch in github action * Removed duplicate definition of the property (#353) * internal/shibboleth-missing-one-error-page * The netId is added to the user which is logged in via shibboleth. * Fixed failing integration tests. * Shib login filter returns the duplicate error * Fixed checkstyle issues * Added an email param into error response * Try to fix IT * Fixed some IT * The user is not registered if he doesn't have the email * Fixed IT - there must be unique handle * migrated-7.5/oai-is-not-working (#355) * Fixed wront `dspace.server.url` property value. * Updated scripts * Updated scripts * Fixed IT - there must be unique handle * Removed changes we don't want to have * Added empty row * Commented out TUL properties (#359) * trigger docker images on correct branch * internal/fix-discojuice-issues (#371) * Added property to disable or allow the discojuice. Fixed cronjob interval for 2 hours. Changed Discojuice logs to DEBUG. * Fixed discojuice interval * In some cases the log shouldn't be in debug mode, but in the error --------- Co-authored-by: Marie Verdonck <[email protected]> Co-authored-by: Tim Donohue <[email protected]> Co-authored-by: jensvannerum <[email protected]> Co-authored-by: Mykhaylo <[email protected]> Co-authored-by: Yana De Pauw <[email protected]> Co-authored-by: Francesco Pio Scognamiglio <[email protected]> Co-authored-by: Nona Luypaert <[email protected]> Co-authored-by: Jens Vannerum <[email protected]> Co-authored-by: Koen Pauwels <[email protected]> Co-authored-by: Mohamed Saber Eskander <[email protected]> Co-authored-by: Toni Prieto <[email protected]> Co-authored-by: corrado lombardi <[email protected]> Co-authored-by: Alexandre Vryghem <[email protected]> Co-authored-by: Kim Shepherd <[email protected]> Co-authored-by: Pascal-Nicolas Becker <[email protected]> Co-authored-by: Agustina Martinez <[email protected]> Co-authored-by: Raf Ponsaerts <[email protected]> Co-authored-by: Andrea Bollini <[email protected]> Co-authored-by: MajoBerger <[email protected]> Co-authored-by: MajoBerger <[email protected]> Co-authored-by: Giuseppe Digilio <[email protected]> Co-authored-by: jensroets <[email protected]> Co-authored-by: HuynhKhoa1601 <[email protected]> Co-authored-by: HuynhKhoa1601 <[email protected]>
* Tul/tmp 4 merge (#401) * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a080aa0d927036e0eae609c3bf1a273d35 (#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * #8629: Make sure temporary worfklow groups of reviewers get deleted * #8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * #8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <[email protected]> Co-authored-by: milanmajchrak <[email protected]> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests * Migrate to 7.5 (#274) * 97298: Self-register - test fixes * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: #8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a080aa0d927036e0eae609c3bf1a273d35 (#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * #8629: Make sure temporary worfklow groups of reviewers get deleted * #8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * #8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <[email protected]> Co-authored-by: milanmajchrak <[email protected]> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <[email protected]> Co-authored-by: Giuseppe Digilio <[email protected]> Co-authored-by: corrado lombardi <[email protected]> Co-authored-by: Mohamed Saber Eskander <[email protected]> Co-authored-by: Koen Pauwels <[email protected]> Co-authored-by: Jens Vannerum <[email protected]> Co-authored-by: jensroets <[email protected]> Co-authored-by: Yana De Pauw <[email protected]> Co-authored-by: Tim Donohue <[email protected]> Co-authored-by: jensvannerum <[email protected]> Co-authored-by: Mykhaylo <[email protected]> Co-authored-by: Francesco Pio Scognamiglio <[email protected]> Co-authored-by: Nona Luypaert <[email protected]> Co-authored-by: Toni Prieto <[email protected]> Co-authored-by: Alexandre Vryghem <[email protected]> Co-authored-by: Kim Shepherd <[email protected]> Co-authored-by: Pascal-Nicolas Becker <[email protected]> Co-authored-by: Agustina Martinez <[email protected]> Co-authored-by: Raf Ponsaerts <[email protected]> Co-authored-by: Andrea Bollini <[email protected]> Co-authored-by: MajoBerger <[email protected]> Co-authored-by: MajoBerger <[email protected]> * Copied fix from 303 * Copied fix from 302, 319, 314 * Copied fix from 331 * Copied fix from 295 * Copied fix from 337, 339 * Removed ClarinLicenseImportRestController.java according to 273 * Eperson.hasPasswordSet was missing and one checkstyle violation as occurred. * Docker image should be generated. * Full BE customization for TUL (#329) * define citace pro in the config file * rename the config and add it into the default res.properties.exposed * configure the gg analytics * add email config propertyy for the contact page * add the email for lr.help.email * remove redundant email --------- Co-authored-by: HuynhKhoa1601 <[email protected]> Co-authored-by: HuynhKhoa1601 <[email protected]> * Temp file * Migrate to 7.5 (#343) * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: #8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a080aa0d927036e0eae609c3bf1a273d35 (#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * #8629: Make sure temporary worfklow groups of reviewers get deleted * #8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * #8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <[email protected]> Co-authored-by: milanmajchrak <[email protected]> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <[email protected]> Co-authored-by: Giuseppe Digilio <[email protected]> Co-authored-by: corrado lombardi <[email protected]> Co-authored-by: Mohamed Saber Eskander <[email protected]> Co-authored-by: Koen Pauwels <[email protected]> Co-authored-by: Jens Vannerum <[email protected]> Co-authored-by: jensroets <[email protected]> Co-authored-by: Yana De Pauw <[email protected]> Co-authored-by: Tim Donohue <[email protected]> Co-authored-by: jensvannerum <[email protected]> Co-authored-by: Mykhaylo <[email protected]> Co-authored-by: Francesco Pio Scognamiglio <[email protected]> Co-authored-by: Nona Luypaert <[email protected]> Co-authored-by: Toni Prieto <[email protected]> Co-authored-by: Alexandre Vryghem <[email protected]> Co-authored-by: Kim Shepherd <[email protected]> Co-authored-by: Pascal-Nicolas Becker <[email protected]> Co-authored-by: Agustina Martinez <[email protected]> Co-authored-by: Raf Ponsaerts <[email protected]> Co-authored-by: Andrea Bollini <[email protected]> Co-authored-by: MajoBerger <[email protected]> Co-authored-by: MajoBerger <[email protected]> * Removed unused class * Updated docker.yml * Updated cfg (#348) * Fixed from port 4000 to 8080 (#350) * add redeploy to dev-5 -> curl call to deploy action * add redeploy to dev-5 -> curl call to deploy action * correct redeploy branch in github action * Removed duplicate definition of the property (#353) * internal/shibboleth-missing-one-error-page * The netId is added to the user which is logged in via shibboleth. * Fixed failing integration tests. * Shib login filter returns the duplicate error * Fixed checkstyle issues * Added an email param into error response * Try to fix IT * Fixed some IT * The user is not registered if he doesn't have the email * Fixed IT - there must be unique handle * migrated-7.5/oai-is-not-working (#355) * Fixed wront `dspace.server.url` property value. * Updated scripts * Updated scripts * Fixed IT - there must be unique handle * Removed changes we don't want to have * Added empty row * Merge actual 7.5. version into TUL (#357) * 102-BE/cannot-read-big-file-by-readAllBytes (#277) * replace readAllBytes * fix test errors * 103-be/shibboleth-login-wrong-error-page (#279) * The user is redireced to the FE after wrong shibboleth authentication. * Changed redirect URLs * Fixed checkstyle issues * Copied ShibbolethFilterIT into ClarinShibbolethFilterIT because the tests did must be updated. * 105-be/user-is-not-registered-after-shibboleth-login (#281) * firstname and lastname is not required for proper Shibboleth login. * Fixed IT to be failed if code is wrong * 88-BE/license-labels-are-missing-icons (#273) * License label icon can be null * user rest repository for license import * Fixed checkstyle issues * Fixed failing IT --------- Co-authored-by: milanmajchrak <[email protected]> * 110-be/imported-item-should-not-regenerate-certain-metadata-fields (#284) * Created test which fail when issue happens * Some metadata values are not updated during the import. * Changed logging (#286) * 116 be/deleted bitstreams cannot be imported (#296) * Every bitstream is deleted after updating it. If the sequenceId is null, use default value. * added logs and fixed error message * Fixed checkstyle issues * Added some logs. --------- Co-authored-by: Michaela Paurikova <[email protected]> * 80-BE/import-tasklistitem (#300) * create method and test * test runs * condition of membership * throw exception soon and explain better (#308) * added commit (#306) * 87-BE/adding-missing-attributes (#303) * add welcome_info and can_edit_submission_metadata * added missing attributes to the database * errors from review * 119-BE/remove-validation-of-deleted-bitstreams (#302) * remove validation control for deleted bitstream * added log * fix review comments * added mvn argument fail-at-end (#319) * added mvn argument fail-at-end * see mvn version * see maven version * -fae * final version of build.yml * 75-BE/missing-handles (#314) * create handle without dspace object * new controller for import handle without dspace object * create handle for workspaceitem * using of existing handle if it exists (#316) * checkstyle * fix failed test * added whitespace after for * review * removed authorization for handle creation * remove unneeded import * checkstyle * 122-be/restricted-item-download-issues (#331) * Initial commit * Remove the error when the ClarinLicense doesn't require any additional user metadata and the file cannot be downloaded because the user didn't fill in any user metadata. * The user cannot download the item with ClarinLicense that doesn't require user metadata, but controller methods required this information. * Be/fixed bitstreams added user metadata (#295) * 116-be/deleted-bitstreams-cannot-be-imported (#291) * Every bitstream is deleted after updating it. If the sequenceId is null, use default value. * added logs and fixed error message * Fixed checkstyle issues * Added some logs. --------- Co-authored-by: Michaela Paurikova <[email protected]> * 76-BE/import-user-metadata (#294) * new controller for user metadata import * import user metadata works based on created tests * remove error from python import * checkstyle * 76-BE/import-user-metadata-with-fixed-bitstream (#307) * new controller for user metadata import * import user metadata works based on created tests * remove error from python import * checkstyle * fix import user_metadata * fix mishmash with eperson_id and user_registration_id * create user registration and eperson separatelly, checkstyle * edited import user metadata * checkstyle --------- Co-authored-by: Michaela Paurikova <[email protected]> Co-authored-by: Paurikova2 <[email protected]> * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <[email protected]> Co-authored-by: milanmajchrak <[email protected]> * Removed not defined search options. (#337) * browse - Updated IT according to updated cfg (#339) * Removed not defined search options. * Updated IT according to a cfg updates. * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests * Migrate to 7.5 (#274) * 97298: Self-register - test fixes * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: #8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervision orders added a new migration script sql tested that supervisors can edit only workspace items * [CST-7756] refactoring * Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation * [CST-7756] monor fix * [CST-7756] added unit tests covering methods with business logic * [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command * [CST-7756] updated license header * 97425: Fix minor issues * [CST-7756] added instructions to migrate subscriptions from previous versions * [CST-7756] after merge checkstyle fix * [CST-7756] extended abstract test * [CST-7756] updated script * 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction * Reinstate config accidentally deleted, added in 30f923a080aa0d927036e0eae609c3bf1a273d35 (#8064) - enables RSS/Atom feeds * [CST-7756] removed subscriptions for items * [CST-7756] minor fix * [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database * [CST-7756] added missing JavaDoc * [CST-7756] code refactoring * [CST-7756] renamed test class in order to reflect its actual behavior * [CST-7756] removed mail template used by previous script * [CST-7756] code refactoring * [CST-7756] removed Items section * [CST-7756] added missing IT * [CST-7754] updated javadoc * [CST-7754] updated comment * [CST-7754] withdrawn item should not allow supervision order * [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. * [TLC-380] Browse links and "by regex" links in item display * [TLC-380] Fix checkstyle and duplicate code * [TLC-380] Further checkstyle fixes * [TLC-380] Further checkstyle fixes * [TLC-380] Refactor browses endpoint for browse link usage * [TLC-249] Improve 'findByFields' browse refactor * [TLC-380] Fix browse resource byFields IT * [TLC-380] Remove unused methods, add ITs * #8629: Make sure temporary worfklow groups of reviewers get deleted * #8629: PR feedback refactor * [CST-7756] implemented community feedbacks * [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. * [CST-7756] renamed a method * [CST-7756] updated subscriptions migration scripts * [CST-7756] removed 'lastModified_dt' index field * [CST-7756] minor refactoring * [CST-7756] added email subject * [CST-7756] added dissemination for generic DSpace Item * [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied * IT fix: ReviewManagers repository wide group, not collection workflow group * Test IT without drop constraint * [CST-7756] restores security check as was originaly * [CST-7756] described beans * #8628: Remove GET shortlivedtokens endpoint & related IT * [TLC-249] Show Identifier Step, pre-register identifiers * [TLC-249] Remove unused import in WorkspaceItemServiceImpl * [TLC-249] Update section count test in SubmissionDefinitionsControllerIT * [TLC-249] Refactor to support better filter usage, PENDING and MINTED status * [TLC-249] Add and expose config for enabling register DOI * [TLC-249] REST backend for identifier config * [TLC-249] Better status return for new DOIs, write new integration tests * [TLC-249] Integration tests, keep GET handling in controller * [TLC-249] Move GET handling back to ItemIdentifierController * [TLC-249] Checkstyle fixes * [TLC-249] Licence header fixes * [TLC-249] Further checkstyle fixes * [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST * [TLC-249] Further IT fix for identifiers * [TLC-249] Licence header fix * [TLC-249] Address review feedback Controller updated to be less DOI-specific in its registration implementation item-status.register renamed to registerDOI display types included in section data, for UI hints comments / javadoc added DOI status text sent instead of number in status data As per tdonohue's revew on 2022-01-18 * [TLC-249] Lint fixes * [TLC-249] Improve model for identifier step data * [TLC-249] Update configuration identifiers.cfg * [TLC-249] Remove unused subclass DataIdentifier * [TLC-249] Update identifier section IT * [TLC-249] Update integration tests for identifier controller * [TLC-249] Fix submission controller IT * [TLC-249] Update canRegisterDOIFeature to check for cfg enabled * [TLC-249] Refactor identifiers create endpoint * [TLC-249] Refactor, include controller 'find DSO' operation * [TLC-249] Throw not implemented for findOne and findAll * [TLC-249] Fixes and improvements as per review feedback * [TLC-249] Checkstyle fix * [TLC-249] return value as id for IdentifierRest * [TLC-249] Fix category type in IdentifierRest * [TLC-249] Update integration tests for IdentifierRestRepository * [TLC-249] Refactor TrueFilter to get instantiated as singleton * [TLC-249] Construct canonical handle URL in identifier item link * [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter * [TL-249] Add always_true_filter to test REST identifier-service.xml config * [TL-249] Add identifiers.cfg and item-filters.xml config to test data * [TL-249] Fix imports * [TL-249] Revert accidental commit to RestResourceController * [TL-249] Javadoc and other small fixes, DOI unit tests * [TL-249] Javadoc and other small fixes Including stripping $Revision$ from filter javadoc. * [TL-249] Checkstyle fix * 99200: Delete items after copies have been requested fix * [CST-7756] added security check into 'subscription-send' script * Alternate way to restart workflow in case of decline * Fix for decline when the delete doesn't persist in context before wfi is created again from same item * [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions * [DURACOM-116] process sorted alphabetically * [TLC-249] Test abandoning of a pending DOI and minting afterwards * [TLC-249] Ensure property identifiers.item-status.register-doi is set * Added missing commit in cleanup method * Update BitstreamStorageServiceImpl.java Amend commit log message * [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list * [DURACOM-116] moved sorting to service * removed the log info * CST-8936 fix permission for bitstream generated by media-filter * Updates to LICENSES_THIRD_PARTY for 7.5 * [maven-release-plugin] prepare release dspace-7.5 * Fixed some compile errors * Fixed some compile errors * Fixed some compile errors * Fixed errors which causes tomcat starting errors * Ignored failing test * Fixed MetadataExportSearchIT - the dateIssued search filter was commented out. * Added a new action which push test image for FE integration tests. * Updated creating of the docker * changed to proper dependency * Updated cfg, fixed error because rest.properties.exposed was defined in two configuration files. * fixed cfg for tests * Copied fixes for the PRs: 277, 279, 281, 273, 284, 286, 296, 300, 308 * Push docker only to migrate-to-7.5 and not to dtq-dev-7.5 * Update migrate-docker.yml Updated docker action name * Updated IT test for Shibboleth auth * Copied ClarinLicenseImportRestController from another branch * Shibboleth autologin error solved - new header must be added into Allowed Headers in the Application.java * Fixed checkstyle issues. * Internal/fix integration tests 75 (#311) * trying action with different ref * fixed checkstyle * updated config, fixed several integration tests * removed old zip file * assurance * dspace.ui.url was changed to http://localhost:4000 * internal/fix-another-integration-tests (#312) * Set Default charset to UTF-8 in Integration tests * Fixed test in the ExternalHandleRestRepositoryIT - problem was with encoding * Fixed WorkspaceItemRestRepositoryIT#patchRejectLicenseTest - the configuration property that disable LicenseValidation was set to false. * Fixed ClarinDiscoveryRestControllerIT.java#discoverFacetsDateTestWithLabels FacetEntryMatcher.dateIssuedFacet(false), was missing * Fixed ClarinDiscoveryRestControllerIT.java#discoverSearchObjectsTestWithBasicQuery missing FacetEntryMatcher.dateIssuedFacet(false), * Fixed ClarinDiscoveryRestControllerIT tests by updating the discovery.xml * Fixed MetadataExportSearchIT.exportMetadataSearchFilterDate - commented out the test for Date Issued date search filter which was removed from the discovery.xml * test (#317) * Initial commit * Fixed SystemWideAlertRestRepositoryIT - wrong Date comparing, the fix was copied from the upstream * Copied fix from the upstream * Enabled distribution license validation. * Update build.yml Added -fae to integration tests * Removed unnecessary check * Revert to DEFAULT_AMOUNT_FORMATS=81 * Fixed lookupPubmed test --------- Co-authored-by: milanmajchrak <[email protected]> Co-authored-by: milanmajchrak <[email protected]> * enable different endpoint to S3 bitstorage (#338) * enable different endpoint to S3 bitstorage * modified tests --------- Co-authored-by: Marie Verdonck <[email protected]> Co-authored-by: Giuseppe Digilio <[email protected]> Co-authored-by: corrado lombardi <[email protected]> Co-authored-by: Mohamed Saber Eskander <[email protected]> Co-authored-by: Koen Pauwels <[email protected]> Co-authored-by: Jens Vannerum <[email protected]> Co-authored-by: jensroets <[email protected]> Co-authored-by: Yana De Pauw <[email protected]> Co-authored-by: Tim Donohue <[email protected]> Co-authored-by: jensvannerum <[email protected]> Co-authored-by: Mykhaylo <[email protected]> Co-authored-by: Francesco Pio Scognamiglio <[email protected]> Co-authored-by: Nona Luypaert <[email protected]> Co-authored-by: Toni Prieto <[email protected]> Co-authored-by: Alexandre Vryghem <[email protected]> Co-authored-by: Kim Shepherd <[email protected]> Co-authored-by: Pascal-Nicolas Becker <[email protected]> Co-authored-by: Agustina Martinez <[email protected]> Co-authored-by: Raf Ponsaerts <[email protected]> Co-authored-by: Andrea Bollini <[email protected]> Co-authored-by: MajoBerger <[email protected]> Co-authored-by: MajoBerger <[email protected]> * Copied fix from 303 * Copied fix from 302, 319, 314 * Copied fix from 331 * Copied fix from 295 * Copied fix from 337, 339 * Removed ClarinLicenseImportRestController.java according to 273 * Eperson.hasPasswordSet was missing and one checkstyle violation as occurred. * Docker image should be generated. * Temp file * Migrate to 7.5 (#343) * 97298: Self-register - test fixes * [CST-7756] Rename type property to subscriptionType in the subscriptionType object * [CST-7756] Fix checkstyle * [CST-7756] fixed database scripts version number * [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. * [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. * 97183 Processing PR review feedback * 97538: Unauthorized tests should now be anonymous * 97538: Remove readability change * 97538: Remove readability change in IT * 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT * 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException * [CST-7604] Configuration updated to highlight Orgunit and Person * 97735: Add a accept range cors header * Fix license issues * 98345 Advanced workflow actions - Parse select reviewers step * 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration * 98433 Reject button mostly works - still triggers a 404 in console though * 98434: Advanced workflow - refactor scoreReview workflow * 98434: IT fix * 98433: Refactoring SingleUserReviewAction & general refactoring in Actions - Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser * 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction * [CST-7756] removed unused param * 98462: Use discovery configurations in browse * [DURACOM-113] add jfif extension on bitstream formats * 98462: Refactor change and add admin tests * 97538: The search rest method should be public * 97538: Alter IT for public vocabulary search method * 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl * 97080: #8613 - Doc for the prefix solr field * Implemented community feedbacks * 97425: Fix issue with sessions null value * 97061: type request param name change to avoid confusion with rest object type & error codes endpoint changes + IT: - missing/wrong query param accountRequestType => 400 bad request - email not valid domain => 422 unprocessable entity * [CST-7756] refactoring & added missing JavaDoc * [CST-7756] removed unused service bean * [CST-7756] minor refactoring according to the rest contract * PR #8619: Removed dependency spring-context-support, not needed in main * [CST-7756] fixed failed tests * [CST-7756] refactoring * [CST-7756] added tests to valid subscription parameters * [CST-7756] added validation logic of params * [CST-7756] renamed some methods & class * [CST-7756] minor fix * [CST-7756] refactored CanSubscribeFeatureIT * 97425: Implement feedback * [CST-7756] minor update * [CST-7756] added missing index field * [CST-7756] added template for subscription content email * [CST-7754] removed old code of supervis…
* Update README-dtq.md Updated migrated and not migrated tables * Update README-dtq.md verification_token and webapp is in the CLARIN-DSpace7
* Changed hiddenButHarvestable to hidden. * dc.date.issued is removed * Revert "dc.date.issued is removed" This reverts commit d5de6c4. * Synchronized with dtq-dev
* Changed hiddenButHarvestable to hidden. * dc.date.issued is removed * Revert "dc.date.issued is removed" This reverts commit d5de6c4.
* Added missing bitstream-formats.xml * Fixed unit test * Updated failed integration tests.
* Initial commit * Working * Fixed checkstyle issue * Fixed failing integration tests * Added doc
* Created test and updated MetadataConverter.java * Fixed checkstyle issues. * Place is used only by the ItemService. * Refactored code.
* added indexing scripts to docker image * extension to index scripts
* The item is created with configured prefix. * The Configuration property configMap is not shared. The right prefix is added during creating the handle. * The handle is correctly composed and the tests are created * epic changed to local because the local handle should be used by default. * Refactoring * Refactoring * Fixed one failing test * Commented out unwanted community configuration. * Fixed failing tests. Instead of changing owningCollection I used Context events. * Fixed checkstyle * Fixed failing IT. It was needed to update configuraition property. * Fixed failing integration tests - the community configuration service wasn't restored.
* Configured `dc.relation` for controlled authority and created test. * Updated VersioningWithRelationshipsTest - updated adding dc.relation metadata.
* fixed dead handle null * fixed null services
* User Metadata is correctly imported - it is not updated but added every time with a transaction_id. * Refactoring and created test * Refactoring
|
We do not need this anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.