ufal/be-collection2item-table-is-not-migrated #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-not-migrated' into ufal/be-collection2item-table-is-not-migrated
milanmajchrak
changed the title
Paurikova2
requested changes
Sep 22, 2023
| try { | ||
| Object obj = parser.parse(new InputStreamReader(request.getInputStream())); | ||
|
|
||
| for (Object entity : (JSONArray) obj) { |
There was a problem hiding this comment.
maybe I will add some control if obj is JSONArray
| throw new RuntimeException("Context is null - cannot import item's mapped collections."); | ||
| } | ||
|
|
||
| // Load List of collection self links |
There was a problem hiding this comment.
do you mean single collection? If not, use collections
There was a problem hiding this comment.
Not I think more collections, not one
| List<DSpaceObject> listDsoFoundInRequest | ||
| = utils.constructDSpaceObjectList(context, requestAsStringList); | ||
|
|
||
| if (listDsoFoundInRequest.size() < 1) { |
There was a problem hiding this comment.
maybe use const for 1, but as you want
There was a problem hiding this comment.
Used CollectionUtils.isEmpty(listDsoFoundInRequest) instead
...e-server-webapp/src/main/java/org/dspace/app/rest/repository/ClarinItemImportController.java
Show resolved
Hide resolved
|
|
||
| private boolean checkIfOwningCollection(Item item, UUID collectionID) { | ||
| return item.getOwningCollection().getID().equals(collectionID); |
There was a problem hiding this comment.
are you sure that item has collection?
There was a problem hiding this comment.
Added a check
| // It is owning collection | ||
| String col1SelfLink = "https://localhost:8080/spring-rest/api/core/collections/" + col1.getID(); | ||
| String col2SelfLink = "https://localhost:8080/spring-rest/api/core/collections/" + col2.getID(); | ||
| String col3SelfLink = "https://localhost:8080/spring-rest/api/core/collections/" + col3.getID(); |
There was a problem hiding this comment.
use const for common parts of links
dspace-server-webapp/src/test/java/org/dspace/app/rest/ClarinItemImportControllerIT.java
Show resolved
Hide resolved
dspace-server-webapp/src/test/java/org/dspace/app/rest/ClarinItemImportControllerIT.java
Show resolved
Hide resolved
milanmajchrak
added a commit
that referenced
this pull request
Jun 19, 2024
* Created endpoint for importing item's mapped collections and created test for it * Fixed checkstyle issues * Fixed conflicts * refactoring * Refactoring according to request changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
I have a big problem with parsing
Content-Type: 'text-uri', because it cannot recognize new line string\npassed from Python. I wanted to use Vanilla endpoint"/api/core/items/{ITEM_UUI}/mappedCollections/"at first, but after a few hours of failing I decided to create a new one/api/clarin/import/item/{ITEM_UUID}/mappedCollections.