Rest api for handle resolution with metadata #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milanmajchrak
requested changes
Sep 16, 2024
...e-server-webapp/src/main/java/org/dspace/app/rest/hdlresolver/HdlResolverRestController.java
Outdated
Show resolved
Hide resolved
...server-webapp/src/test/java/org/dspace/app/rest/hdlresolver/HdlResolverRestControllerIT.java
Outdated
Show resolved
Hide resolved
vidiecan
requested changes
Sep 16, 2024
...e-server-webapp/src/main/java/org/dspace/app/rest/hdlresolver/HdlResolverRestController.java
Show resolved
Hide resolved
milanmajchrak
requested changes
Oct 8, 2024
...server-webapp/src/test/java/org/dspace/app/rest/hdlresolver/HdlResolverRestControllerIT.java
Outdated
Show resolved
Hide resolved
milanmajchrak
previously approved these changes
Oct 8, 2024
vidiecan
requested changes
Oct 8, 2024
...e-server-webapp/src/main/java/org/dspace/app/rest/hdlresolver/HdlResolverRestController.java
Outdated
Show resolved
Hide resolved
...e-server-webapp/src/main/java/org/dspace/app/rest/hdlresolver/HdlResolverRestController.java
Outdated
Show resolved
Hide resolved
...e-server-webapp/src/main/java/org/dspace/app/rest/hdlresolver/HdlResolverRestController.java
Outdated
Show resolved
Hide resolved
Paurikova2
requested review from
vidiecan and
milanmajchrak
and removed request for
vidiecan
milanmajchrak
approved these changes
Oct 14, 2024
vidiecan
requested changes
Oct 17, 2024
...e-server-webapp/src/main/java/org/dspace/app/rest/hdlresolver/HdlResolverRestController.java
Show resolved
Hide resolved
vidiecan
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
Return title, repository , submitdate and reportemail metadata for handle. not only url.
The new Handle server project (link) uses this code or this code to get a URL for a specific handle.
The endpoint "/resolve/" can be found in HdlResolverRestController.java and here.
I want to modify this endpoint so that if a parameter is provided (or in some other way, such as updating the URL, HTTP request parameters, etc.), it will return a List Map, i.e., instead of https://dev-5.pc:8443/server/resolve/11234/1-5419 which returns ["AAA"], it should return [{"url": "AAA", OTHER METADATA}] where other metadata is like in http://hdl.handle.net/11025/57448?noredirect which is in HandlePlugin.java.
NOTE: (Note, you restarted Docker during the import and handle.remote-resolver.enabled = true is set to false, which is why /resolve/ does not work.)
SUMMARY: Instead of ["string"], I want /resolve/* [{}].