modified submission based on SAV requirements #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milanmajchrak
requested changes
Jan 7, 2025
dspace/config/submission-forms.xml
Outdated
| <required/> | ||
| <regex>http.*</regex> | ||
| <hint>An unambiguous reference to the resource within a given context.</hint> | ||
| <required>You must enter an unambiguous reference to the resource.</required> |
There was a problem hiding this comment.
I think it is not required
| @@ -143,60 +128,26 @@ | |||
| <label>Publisher</label> | |||
| <style>col-sm-8</style> | |||
| <input-type autocomplete-custom="solr-publisher_ac">autocomplete</input-type> | |||
| <hint>Enter the name of the publisher of the previously issued instance of this item, or your home | |||
| institution. Start typing the publisher and use autocomplete form that will appear if | |||
| <hint>An entity responsible for making the resource available. | |||
There was a problem hiding this comment.
Why did you change the hint message?
There was a problem hiding this comment.
I changed it based on their requirements.
| @@ -61,75 +61,60 @@ | |||
| <repeatable>true</repeatable> | |||
| <label>Select type of your resource</label> | |||
| <input-type value-pairs-name="common_types">dropdown</input-type> | |||
| <hint>Type of the resource: "Corpus" refers to text, speech and multimodal corpora. | |||
| <hint>The nature or genre of the resource. | |||
There was a problem hiding this comment.
Why did you change the hint message?
There was a problem hiding this comment.
I changed it based on their requirements.
Comment on lines
-153
to
-186
| <row> | ||
| <field> | ||
| <dc-schema>local</dc-schema> | ||
| <dc-element>hidden</dc-element> | ||
| <dc-qualifier/> | ||
| <repeatable>true</repeatable> | ||
| <label>Should this item be hidden from browse/search? (Admin only field)</label> | ||
| <style>col-sm-4</style> | ||
| <input-type value-pairs-name="hidden_list">list</input-type> | ||
| <hint>Indicate whether you want to hide this item from browse and search. Combine with "Upload cmdi" | ||
| for weblicht submissions. | ||
| </hint> | ||
| <required/> | ||
| <acl> | ||
| policy=deny,action=read,grantee-type=user,grantee-id=* | ||
| </acl> | ||
| </field> | ||
| </row> | ||
| <row> | ||
| <field> | ||
| <dc-schema>local</dc-schema> | ||
| <dc-element>hasCMDI</dc-element> | ||
| <repeatable>true</repeatable> | ||
| <label>Are you going to upload cmdi file? (Admin only field)</label> | ||
| <input-type value-pairs-name="hasCMDI_checkbox">list</input-type> | ||
| <hint>Indicate whether you will upload cmdi file in the next step. Combine with "hide" for weblicht | ||
| submissions. | ||
| </hint> | ||
| <required></required> | ||
| <acl> | ||
| policy=deny,action=read,grantee-type=user,grantee-id=* | ||
| </acl> | ||
| </field> | ||
| </row> |
There was a problem hiding this comment.
but why do we want it when it is not in customer requirements?
| <row> | ||
| <field> | ||
| <dc-schema>dc</dc-schema> | ||
| <dc-element>contributor</dc-element> |
There was a problem hiding this comment.
Keep the contibutor author
dspace/config/submission-forms.xml
Outdated
| <input-type>textarea</input-type> | ||
| <hint>A bibliographic reference for the resource.</hint> | ||
| <required>Please enter a bibliographic reference(s) for the resource.</required> | ||
| <vocabulary>srsc</vocabulary> |
dspace/config/submission-forms.xml
Outdated
| <input-type>textarea</input-type> | ||
| <hint>A summary of the resource.</hint> | ||
| <required>Please enter a summary of the resource.</required> | ||
| <vocabulary>srsc</vocabulary> |
There was a problem hiding this comment.
I did not understand its using. It can be used by tag label, no textarea.
dspace/config/submission-forms.xml
Outdated
| <input-type>textarea</input-type> | ||
| <hint>A list of subunits of the resource.</hint> | ||
| <required>Please enter a list of subunits of the resource.</required> | ||
| <vocabulary>srsc</vocabulary> |
There was a problem hiding this comment.
I did not understand its using. It can be used by tag label, no textarea.
dspace/config/submission-forms.xml
Outdated
| <input-type>textarea</input-type> | ||
| <hint>Information about who access the resource or an indication of its security status. Access Rights may include information regarding access or restrictions based on privacy, security, or other policies.</hint> | ||
| <required>Please enter an information about the access right(s).</required> | ||
| <vocabulary>srsc</vocabulary> |
dspace/config/submission-forms.xml
Outdated
| policy=deny,action=read,grantee-type=user,grantee-id=* | ||
| </acl> | ||
| <dc-schema>dc</dc-schema> | ||
| <dc-element>accessRights</dc-element> |
There was a problem hiding this comment.
Use dc.rights like in the ZCU
https://github.com/dataquest-dev/DSpace/blob/customer/zcu-data/dspace/config/submission-forms.xml#L1214
milanmajchrak
requested changes
Jan 7, 2025
dspace/config/submission-forms.xml
Outdated
Comment on lines
140
to
142
| <dc-element>contributor</dc-element> | ||
| <repeatable>true</repeatable> | ||
| <label>Contributor</label> |
There was a problem hiding this comment.
<dc-schema>dc</dc-schema>
<dc-element>contributor</dc-element>
<dc-qualifier>author</dc-qualifier>
<repeatable>true</repeatable>
<label>Authors</label>
…etable option to some fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description