Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/import-files-to-item #126

Merged
merged 11 commits into from
Feb 26, 2024
Merged

internal/import-files-to-item #126

merged 11 commits into from
Feb 26, 2024

Conversation

milanmajchrak
Copy link
Collaborator

Phases MP MM MB MR JM Total
ETA 0 0 0 0 0 0
Developing 0 5 0 0 0 0
Review 0 0 0 0 0 0
Total - - - - - 0
ETA est. 0
ETA cust. - - - - - 0

Problem description

@milanmajchrak milanmajchrak self-assigned this Jan 9, 2024
@milanmajchrak milanmajchrak requested a review from vidiecan January 9, 2024 13:45
vidiecan
vidiecan requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@vidiecan vidiecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you added 100 equal files, like really?!

vidiecan
vidiecan requested changes Jan 9, 2024
View reviewed changes
data_pump/utils.py Outdated Show resolved Hide resolved
support/dspace_interface/client.py Outdated Show resolved Hide resolved
@milanmajchrak
Copy link
Collaborator Author

you added 100 equal files, like really?!

Yes, you asked me to create an item and import a huge bunch of files. The assignment was clear. What do you want to have imported there?

vidiecan
vidiecan requested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@vidiecan vidiecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

summary of our talk:

  1. add 1 file to git, import it 100x
  2. is src/dspace/_rest.py really the place for dspace.object specific rest calls?

@vidiecan vidiecan requested a review from MajoBerger February 22, 2024 19:09
MajoBerger
MajoBerger approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@MajoBerger MajoBerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested, but I see no obvious flaw

@MajoBerger MajoBerger merged commit 5d552d1 into main Feb 26, 2024
1 check failed
@MajoBerger MajoBerger deleted the internal/import-files-to-item branch February 26, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MajoBerger MajoBerger MajoBerger approved these changes

@vidiecan vidiecan Awaiting requested review from vidiecan

Assignees

@milanmajchrak milanmajchrak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milanmajchrak @vidiecan @MajoBerger