len comparing of tables by own sql #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidiecan
requested changes
Jul 8, 2024
src/pump/_db.py
Outdated
| @@ -161,7 +161,7 @@ def __init__(self, raw_db_dspace_5, raw_db_utilities_5, raw_db_7): | |||
| self.raw_db_7 = raw_db_7 | |||
|
|
|||
| def _fetch_all_vals(self, db5, table_name: str, sql: str = None): | |||
| sql = f"SELECT * FROM {table_name}" | |||
| sql = sql = f"SELECT * FROM {table_name}" if sql is None else sql | |||
There was a problem hiding this comment.
Suggested change
| sql = sql = f"SELECT * FROM {table_name}" if sql is None else sql | |
| sql = sql or f"SELECT * FROM {table_name}" |
vidiecan
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Table [ collection2item] !!! WARN !!! compared by len only v5:[67146], v7:[66929]
Explanation: In version 6, there is redundant data, whereas in version 7, only unique values are present.
I've added a new condition to the validation table for custom SQL definitions to compare table lengths.