Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning about importing deleted bitstream #165

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Paurikova2
Copy link
Collaborator

@Paurikova2 Paurikova2 commented Oct 3, 2024

Phases MP MM MB MR JM Total
ETA 0 0 0 0 0 0
Developing 0.1 0 0 0 0 0
Review 0 0 0 0 0 0
Total - - - - - 0
ETA est. 0
ETA cust. - - - - - 0

Problem description

During Ondrej's bitstream import, two bitstreams were not imported. These bitstreams are deleted and in logs there is not info about importing deleted bitstreams.

Solution

Added warning about importing of deleted bitstreams to import logs.

Test

Check if the deleted bitstreams are unvisible.
Solution: In Ondrej's dump, there are around 145 deleted bitstreams. If an item is deleted, all associated records of this item from other tables are also missing. We cannot find the name of the item, so we cannot check it on Lindat. For the test, we deleted an existing item and checked the records of this item in associated tables. Since we knew the item's name, we could check if we could still find the item or not. We could not see it, which is the desired result.

@Paurikova2 Paurikova2 linked an issue Oct 3, 2024 that may be closed by this pull request
@milanmajchrak milanmajchrak requested review from vidiecan and removed request for vidiecan October 8, 2024 07:15
@milanmajchrak milanmajchrak merged commit c77dd51 into main Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import deleted bitstream more detailed
2 participants