Mongodb collection drop function #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrapy/idiomatic/collection.py
Outdated
| @@ -216,6 +216,9 @@ def delete_many( | |||
| f"(gotten '${json.dumps(dm_response)}')" | |||
| ) | |||
|
|
|||
| def drop(self, name_or_collection: Union[str, AsyncCollection]) -> None: | |||
There was a problem hiding this comment.
As a method on "collection", it has no "name_or_collection" argument (see ref), it being implied that the one to drop is self.
note: The Mongo docs use the term "alias" pretty liberally here IMO :D
astrapy/idiomatic/collection.py
Outdated
| @@ -445,6 +448,10 @@ async def delete_many( | |||
| f"(gotten '${json.dumps(dm_response)}')" | |||
| ) | |||
|
|
|||
| async def drop(self, name_or_collection: Union[str, AsyncCollection]) -> None: | |||
| return await self._astra_db_collection.astra_db.delete_collection(name_or_collection) | |||
There was a problem hiding this comment.
same for the async, and incidentally I am surprised if this typechecks ...
|
Can you confirm this is subsumed by #231 (as it seems to me?) In that case, please close. |
Base automatically changed from
pymongo-convergence-m1
to
mongodb-database-attributes
March 5, 2024 22:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a function for a collection to drop itself: collection.drop(COLLECTION_NAME).
Added a test to validate that it's working. It seems like a ddl sort of thing so that's where I put it.