Rewords comment describing WRITETIME/TTL settings #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msmygit
reviewed
Dec 19, 2023
auto-merge was automatically disabled
March 19, 2024 19:32
Head branch was pushed to by a user without write access
msmygit
requested changes
Dec 6, 2024
arvy
force-pushed
the
rewording-comment
branch
from
751f0ea to
2450614
Compare
|
I also removed the eclipse project files .classpath/.project - they are specified in the .gitignore list, which results in some funkiness. ..it might be easier to do this on the main branch (lmk) |
arvy
force-pushed
the
rewording-comment
branch
from
2450614 to
df7a4c0
Compare
msmygit
force-pushed
the
rewording-comment
branch
from
df7a4c0 to
0db343d
Compare
pravinbhat
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Comment rewording based on feedback from a previous PR (the other PR was merged before I had a chance to make this change)