Skip to content

Commit

Permalink
more comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jbellis committed Nov 22, 2024
1 parent cd1303d commit 5b296bb
Showing 1 changed file with 7 additions and 12 deletions.
19 changes: 7 additions & 12 deletions src/java/org/apache/cassandra/db/filter/ColumnFilter.java
Original file line number Diff line number Diff line change
Expand Up @@ -297,14 +297,16 @@ public static ColumnFilter selection(TableMetadata metadata,
}

/**
* The columns that needs to be fetched internally for this filter.
* The columns that needs to be fetched internally. See FetchingStrategy for why this is almost
* always a superset of the queried columns.
*
* @return the columns to fetch for this filter.
*/
public abstract RegularAndStaticColumns fetchedColumns();

/**
* The columns actually queried by the user.
* The columns needed to process the query, including selected columns, ordering columns,
* restriction (predicate) columns, and synthetic columns.
* <p>
* Note that this is in general not all the columns that are fetched internally (see {@link #fetchedColumns}).
*/
Expand Down Expand Up @@ -621,9 +623,7 @@ private SortedSetMultimap<ColumnIdentifier, ColumnSubselection> buildSubSelectio
*/
public static class WildCardColumnFilter extends ColumnFilter
{
/**
* The queried and fetched columns.
*/
// for wildcards, there is no distinction between fetched and queried because queried is already "everything"
private final RegularAndStaticColumns fetchedAndQueried;

/**
Expand Down Expand Up @@ -741,14 +741,9 @@ public static class SelectionColumnFilter extends ColumnFilter
{
public final FetchingStrategy fetchingStrategy;

/**
* The selected columns
*/
// Materializes the columns required to implement queriedColumns() and fetchedColumns(),
// see the comments to superclass's methods
private final RegularAndStaticColumns queried;

/**
* The columns that need to be fetched to be able
*/
private final RegularAndStaticColumns fetched;

private final SortedSetMultimap<ColumnIdentifier, ColumnSubselection> subSelections; // can be null
Expand Down

0 comments on commit 5b296bb

Please sign in to comment.