Skip to content

Commit

Permalink
CNDB-9877: Update PR template
Browse files Browse the repository at this point in the history
  • Loading branch information
@jacek-lewandowski
jacek-lewandowski committed Oct 31, 2024
1 parent f9e44c8 commit a655a15
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/pull_request_template.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
...

### Checklist before you submit for review
- [ ] Make sure there is a PR in the CNDB project updating the Converged Cassandra version
- [ ] Make sure there is a PR in the CNDB project updating the Converged Cassandra version if your PR is changing the API
- [ ] Use `NoSpamLogger` for log lines that may appear frequently in the logs
- [ ] Verify test results on Butler
- [ ] Test coverage for new/modified code is > 80%
- [ ] Verify Butler and Sonar checks are passing
- [ ] Proper code formatting
- [ ] Proper title for each commit staring with the project-issue number, like CNDB-1234
- [ ] Each commit has a meaningful description
- [ ] Each commit is not very long and contains related changes
- [ ] Renames, moves and reformatting are in distinct commits
- [ ] Each commit contains related changes
- [ ] Renames, moves and reformatting are in distinct commits
- [ ] Avoid starting nodes in new tests (jvm dtests, CQLTester) if possible in favor of implementing pure unit tests

1 comment on commit a655a15

@cassci-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build rejected: 4 NEW test failure(s) in 1 builds.
Butler analysis done on ds-cassandra-pr-gate/CNDB-9877-2 vs last 16 runs of ds-cassandra-build-nightly/main.

Status Test Description Branch story Upstream story
❌ NodesTest.testPeersSerialization test is constantly failing. No failures on upstream 🔴 🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵
❌ NodeToolEnableDisableBinaryTest.testMaybeChangeDocs test is constantly failing. No failures on upstream 🔴 🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵
❌ ReducingKeyIteratorTest.testTotalAndReadBytesManySSTables test is constantly failing. No failures on upstream 🔴 🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵
❌ VectorSiftSmallTest.testMultiSegmentBuild test is constantly failing. No failures on upstream 🔴 🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵
butler comparison

Please sign in to comment.