Add coordinator MEMORY_BYTES sensor for reads #1452
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymkhalil
commented
Dec 5, 2024
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| public class CoordinatorSensorsTest extends CQLTester |
There was a problem hiding this comment.
For testing internode message (and memory bytes from received internode message) our best shot would be dtests. Will move there once cndb-8501 is merged as it will could reuse/refactor some of the stuff. Other non-CNDB test ideas are welcome
There was a problem hiding this comment.
update: internode is out of scope for now. I added an initial dtest anyway to exercise the code paths on the callback from replicas
aymkhalil
commented
Dec 12, 2024
| ? message.getPayloadSerializer().serializedSize(message.payload, version) | ||
| : 0; | ||
| // TODO: remove and properly fix NPE when calling message.serializedSize(MessagingService.current_version) |
There was a problem hiding this comment.
Confirmed this is legacy verb REQUEST_RSP:
No payload serializer found for verb REQUEST_RSP, responseVerb null, payload org.apache.cassandra.db.ReadResponse$RemoteDataResponse@c9f4b69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
Draft for https://github.com/riptano/cndb/issues/11544
This PR is based off cndb-8501 for now.
What does this PR fix and why was it fixed
Tracks coordinator memory bytes for reads and range reads
Checklist before you submit for review
NoSpamLoggerfor log lines that may appear frequently in the logs