Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDB-12240: Allow custom internode outbound metrics #1470

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

driftx
Copy link

@driftx driftx commented Dec 20, 2024

What is the issue

These metrics needs to be customizable.

What does this PR fix and why was it fixed

Allow custom implementations.

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

@jkni
Copy link

jkni commented Dec 20, 2024

LGTM. Are you also planning to expose InboundConnections' metrics? It seems straightforward enough to do here all at once.

@driftx
Copy link
Author

driftx commented Dec 20, 2024

Realized I need further changes here that will be more outbound-specific, so I'll update with those when ready.

@driftx driftx changed the title CNDB-12240: Make OutboundConnections' metrics public CNDB-12240: Allow custom internode outbound metrics Dec 20, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
27.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1470 rejected by Butler


1 new test failure(s) in 4 builds
See build details here


Found 1 new test failures

Test Explanation Branch history Upstream history
...adRepairGuarantees.test_atomic_writes[blocking] regression 🔴🔴🔴🔴 🔵🔵🔵🔵🔵🔵🔵

Found 431 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants