Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDB-12272: Fix SimpleClientPerfTest #1477

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CNDB-12272: Fix SimpleClientPerfTest #1477

wants to merge 2 commits into from

Conversation

djatnieks
Copy link

What is the issue

SimpleClientPerfTest has been failing in CI since changes from CNDB-10759

What does this PR fix and why was it fixed

This change in SimpleClientPerfTest, updates the anonymous class Message.Codec<QueryMessage> to override the correct method, public CompletableFuture<Response> maybeExecuteAsync from QueryMessage, whose signature was changed as part of CNDB-10759.

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

@djatnieks djatnieks self-assigned this Dec 23, 2024
@djatnieks
Copy link
Author

SimpleClientPerfTest also needed the same fix

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1477 rejected by Butler


1 new test failure(s) in 2 builds
See build details here


Found 1 new test failures

Test Explanation Branch history Upstream history
...c.VectorTypeTest.createIndexAfterInsertTest[ca] regression 🔴🔵 🔵🔵🔵🔵🔵🔵🔵

Found 7 known test failures

@djatnieks djatnieks removed their assignment Dec 24, 2024
@djatnieks djatnieks requested a review from jakubzytka December 24, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants