Add support for retries #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpenick
commented
Jan 11, 2022
proxy/proxy_retries_test.go
Outdated
| { // Error response (truncate), retry until succeeds or exhausts query plan | ||
| idempotentQuery, | ||
| &message.TruncateError{ErrorMessage: "Truncate"}, | ||
| "cql error: ERROR UNAVAILABLE (code=ErrorCode Unavailable [0x00001000], msg=No more hosts available (exhausted query plan), cl=ConsistencyLevel ANY [0x0000], required=0, alive=0)", |
There was a problem hiding this comment.
This should probably not verify against the exact error string. This is a bit fragile.
dougwettlaufer
approved these changes
Jan 11, 2022
joao-r-reis
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
Looks good to me, I added a couple of questions and a couple of tiny suggestions regarding the tests.
I always read tests first because I see them as a kind of documentation when I'm reading new code and it was pretty easy to follow the expected behavior of the code by following your tests 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final issue that fixes: #3. Previous PRs added the ability to detect if requests are idempotent. With this information and a retry policy we can automatically handle a number of server-side failures that are usually handled by the driver, but would not be possible with driver though the proxy (because its view is a single node cluster).