CLI and README updates #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polandll
suggested changes
Feb 10, 2022
README.md
Outdated
| --astra-token <astra-token> --astra-database-id <astra-datbase-id> | ||
| ``` | ||
|
|
||
| The proxy also support using the Astra Secure Connect Bundle, but it requires mounting the bundle to a volume in the container. |
There was a problem hiding this comment.
You need to put in a link for the scb - how to get it.
Co-authored-by: Lorina Poland <[email protected]>
polandll
approved these changes
Feb 10, 2022
joao-r-reis
approved these changes
Feb 11, 2022
proxycore/connpool.go
Outdated
| @@ -209,6 +211,7 @@ func (p *connPool) stayConnected(idx int) { | |||
| done = true | |||
| _ = conn.Close() | |||
| case <-conn.IsClosed(): | |||
| p.logger.Warn("pool closed", zap.Stringer("host", p.config.Endpoint)) | |||
There was a problem hiding this comment.
I'm not sure if Warn is the best log level here. In Astra coordinator topology changes are somewhat common (tenant allocation/deallocation, upgrades) so it might "scare" users without a good reason when they eventually see these warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small refactor of the cli flags. I've added an
astraprefix to the Astra specific options e.g.--astra-bundle(ASTRA_BUNDLEfor the env. variable).I've also update the README for the updated options including using an Astra Token (instead of the secure connect bundle).
I haven't update the k8s instruction, but I've created a follow up ticket: #77. The main reason for doing this is I'm not a fan of the current instructions because they should be putting the client secrets in the secret store instead of the command. I need to run through a setup where I use the new astra token options with the k8s secrets.