only generate checkpoint file when the job does not complete #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
suggested changes
Aug 16, 2022
| @@ -254,7 +254,7 @@ public void reportAvailableFiles() throws IOException { | |||
| } | |||
| if (checkpointEnabled) { | |||
| CheckpointManager manager = mergeCheckpointManagers(); | |||
| if (!manager.isEmpty()) { | |||
| if (!manager.isEmpty() && !manager.isComplete(replayStrategy)) { | |||
There was a problem hiding this comment.
This will indeed fix the issue but will trigger a bunch of integration test failures because we have a few tests expecting such a file to be generated. Especially the tests in CSVEndToEndSimulacronIT.
There was a problem hiding this comment.
@adutra I see what you're talking about. Basically we need to address the following 10 integration test failures, right?
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] CSVEndToEndSimulacronIT.full_load:202
Expecting path:
/var/folders/kt/wswnnkcn1mxg8bkdxwm_6k1h0000gn/T/logs8486694306328228675/LOAD_20220816-160910-818666/checkpoint.csv
to exist (symbolic links were followed).
[ERROR] CSVEndToEndSimulacronIT.full_unload:1209
Expecting path:
/var/folders/kt/wswnnkcn1mxg8bkdxwm_6k1h0000gn/T/logs2302077949864412390/UNLOAD_20220816-160916-095270/checkpoint.csv
to exist (symbolic links were followed).
[ERROR] CSVEndToEndSimulacronIT.full_unload_csv_default_modification:1288
Expecting path:
/var/folders/kt/wswnnkcn1mxg8bkdxwm_6k1h0000gn/T/logs5564278254796049513/UNLOAD_20220816-160910-627139/checkpoint.csv
to exist (symbolic links were followed).
[ERROR] CSVEndToEndSimulacronIT.full_unload_large_result_set:1320
Expecting path:
/var/folders/kt/wswnnkcn1mxg8bkdxwm_6k1h0000gn/T/logs1208374229285479517/UNLOAD_20220816-160917-095643/checkpoint.csv
to exist (symbolic links were followed).
[ERROR] CSVEndToEndSimulacronIT.massive_load_with_errors:896
Expecting path:
/var/folders/kt/wswnnkcn1mxg8bkdxwm_6k1h0000gn/T/logs7228255075026913737/LOAD_20220816-160914-338597/checkpoint.csv
to exist (symbolic links were followed).
[ERROR] CSVEndToEndSimulacronIT.massive_unload_with_errors:1128
Expecting path:
/var/folders/kt/wswnnkcn1mxg8bkdxwm_6k1h0000gn/T/logs5864708909355599806/UNLOAD_20220816-160919-971570/checkpoint.csv
to exist (symbolic links were followed).
[ERROR] CSVEndToEndSimulacronIT.massive_unload_with_errors:1128
Expecting path:
/var/folders/kt/wswnnkcn1mxg8bkdxwm_6k1h0000gn/T/logs7558778109783596575/UNLOAD_20220816-160922-513469/checkpoint.csv
to exist (symbolic links were followed).
[ERROR] CSVEndToEndSimulacronIT.unload_binary:1531
Expecting path:
/var/folders/kt/wswnnkcn1mxg8bkdxwm_6k1h0000gn/T/logs4874744943006336612/UNLOAD_20220816-160916-867395/checkpoint.csv
to exist (symbolic links were followed).
[ERROR] CSVEndToEndSimulacronIT.unload_binary:1531
Expecting path:
/var/folders/kt/wswnnkcn1mxg8bkdxwm_6k1h0000gn/T/logs7539088680158356009/UNLOAD_20220816-160916-899891/checkpoint.csv
to exist (symbolic links were followed).
[ERROR] CSVEndToEndSimulacronIT.validate_stdout:1488
Expecting path:
/var/folders/kt/wswnnkcn1mxg8bkdxwm_6k1h0000gn/T/logs667372273589927031/UNLOAD_20220816-160916-807864/checkpoint.csv
to exist (symbolic links were followed).
[INFO]
[ERROR] Tests run: 75, Failures: 10, Errors: 0, Skipped: 0
There was a problem hiding this comment.
There are many more I'm afraid. Our internal CI shows a lot of failures in CSVConnectorEndToEndCCMIT and JsonConnectorEndToEndCCMIT.
You can run CCM tests locally by enabling the medium profile:
mvn clean install -Pmedium
Side note: we should reserve the branches ending with .x for releases only. Next time, please fork the repo and create a branch targeting 1.10.x and base your PR on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.