fix

datastax · Apr 9, 2024 · 00eb4e2 · 00eb4e2
1 parent f8b8e60
commit 00eb4e2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/pulsar-jms/src/test/java/com/datastax/oss/pulsar/jms/VirtualDestinationsConsumerTest.java b/pulsar-jms/src/test/java/com/datastax/oss/pulsar/jms/VirtualDestinationsConsumerTest.java
@@ -465,8 +465,8 @@ public void testPatternConsumerAddingTopicWithServerSideFilters() throws Excepti
             pulsarContainer
                 .getAdmin()
                 .topics()
-                .createSubscription(
-                    topicName, "jms-queue", MessageId.earliest, false, subscriptionProperties);
+                .updateSubscriptionProperties(
+                    topicName, "jms-queue", subscriptionProperties);
 
             Queue newDestination = session.createQueue(topicName);
             TextMessage nextMessage = session.createTextMessage("new");

diff --git a/pulsar-jms/src/test/java/com/datastax/oss/pulsar/jms/utils/PulsarContainerExtension.java b/pulsar-jms/src/test/java/com/datastax/oss/pulsar/jms/utils/PulsarContainerExtension.java
@@ -31,6 +31,7 @@
 
 @Slf4j
 public class PulsarContainerExtension implements BeforeAllCallback, AfterAllCallback {
+  public static final String PULSAR_IMAGE = "apachepulsar/pulsar:3.0.0";
   private PulsarContainer pulsarContainer;
   private Consumer<PulsarContainerExtension> onContainerReady;
   private Map<String, String> env = new HashMap<>();
@@ -67,7 +68,7 @@ public void afterAll(ExtensionContext extensionContext) {
   public void beforeAll(ExtensionContext extensionContext) {
     network = Network.newNetwork();
     pulsarContainer =
-        new PulsarContainer(DockerImageName.parse("apachepulsar/pulsar:3.0.0"))
+        new PulsarContainer(DockerImageName.parse(PULSAR_IMAGE))
             .withNetwork(network)
             .withEnv(env)
             .withLogConsumer(
@@ -76,13 +77,13 @@ public void beforeAll(ExtensionContext extensionContext) {
                 MountableFile.forHostPath("target/classes/filters"), "/pulsar/filters");
     // start Pulsar and wait for it to be ready to accept requests
     pulsarContainer.start();
+    admin =
+            PulsarAdmin.builder()
+                    .serviceHttpUrl("http://localhost:" + pulsarContainer.getMappedPort(8080))
+                    .build();
     if (onContainerReady != null) {
       onContainerReady.accept(this);
     }
-    admin =
-        PulsarAdmin.builder()
-            .serviceHttpUrl("http://localhost:" + pulsarContainer.getMappedPort(8080))
-            .build();
   }
 
   public PulsarContainerExtension withOnContainerReady(