JMS Selectors: apply selectors on the write path (initial prototype) #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
changed the title
Comment on lines
+94
to
+98
| if (filterResult == EntryFilter.FilterResult.REJECT) { | ||
| String property = "filter-result-" + name + "@" + subscription.getTopicName(); | ||
| publishContext.setProperty(property, filterResult); | ||
| publishContext.setProperty(JMS_FILTERED_PROPERTY, true); | ||
| } |
There was a problem hiding this comment.
A follow up optimization can use these fields to skip the post filtering step.
Comment on lines
+125
to
+131
| // ir is possible that calling this method in this thread may affect performance | ||
| // let's keep it simple for now, we can optimize it later | ||
| subscription.acknowledgeMessage( | ||
| Collections.singletonList(new PositionImpl(ledgerId, entryId)), | ||
| CommandAck.AckType.Individual, | ||
| null); | ||
| } |
There was a problem hiding this comment.
I'm pretty sure acknowledging the message should be fast. It might get slowed down by synchronization, but I would expect the pre-filtering to be the thing that is most disruptive.
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new BrokerInterceptor that applies the Filters on the Write Path and acknowledges the message that don't match the filter.
With this change the backlog metric is more accurate and there is less work to do while dispatching the messages.
In the other hand, we are adding more load on the write path.
Please note that we still have to apply the filter while dispatching the messages because:
How to enable this feature:
You also have to copy the jms filters .nar file into the 'interceptors' directory (the same file you put in the 'filters' directory)