Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STREAM-546] JMS 11 Support excluding ServerSideFiltering #165

Merged
merged 17 commits into from
Jan 7, 2025

Conversation

sandeep-ctds
Copy link
Contributor

@sandeep-ctds sandeep-ctds commented Dec 27, 2024

Summary Of Changes

  • Formatting fixes so that running mvn commands won't change the file format.
  • Forked required filters code from activemq-client version 6.0.0 and removed it's dependency from the entire project. Updated pom.xml for all the modules impacted.
  • Divided pulsar-jms-filters module into pulsar-jms-filters-common and pulsar-jms-filters modules.
  • Update parent pom.xml maven plugin to use JDK11 , pulsar-jms-spring-example and pulsar-jms-filters modules to use JDK17 as required.

pulsar-jms-filters-common module supports JDK11 and is part of client side code. pulsar-jms-filters module supports JDK17 and is deployed on the server as the nar file.

For more information, the following unnecessary imports and code is removed from the forked activemq-client code to make the jar size smaller.

  • ActiveMQTempDestination - Removed ActiveMQConnection instance variable and related
  • BrokerInfo - Removed CommandVisitor import and related unused method
  • Command - Removed CommandVisitor import and related unused method
  • ProducerInfo - Removed CommandVisitor import and related unused method
  • RemoveInfo - Removed CommandVisitor import and related unused method
  • Response - Removed CommandVisitor import and related unused method
  • SessionInfo - Removed CommandVisitor import and related unused method
  • SessionInfo - Removed ConnectionInfo and related
  • Message - Added static variable. Helped in removing Advisor import. public static final String ADIVSORY_MESSAGE_TYPE = "Advisory";
  • Message - Removed ActiveMQConnection instance variable and related
  • ActiveMQMessage - checkValidObject(value) method and its references
  • ActiveMQMessage - convertScheduled(name, value) method and its references
  • ActiveMQMessage - Removed CommandVisitor import and related unused method

@sandeep-ctds sandeep-ctds marked this pull request as draft December 27, 2024 13:43
@sandeep-ctds sandeep-ctds marked this pull request as ready for review December 31, 2024 21:35
@sandeep-ctds sandeep-ctds requested a review from eolivelli January 2, 2025 08:24
Copy link
Collaborator

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Great work

@eolivelli eolivelli merged commit be15cbd into master Jan 7, 2025
3 checks passed
@eolivelli eolivelli deleted the jms-11-support branch January 7, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants