[fix][broker] Allow broker deployment in heterogeneous hw config cluster without restricting nic speed detection #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhil-ctds
force-pushed
the
nics-fix
branch
from
491169e to
914e937
Compare
dlg99
approved these changes
Nov 15, 2024
srinath-ctds
approved these changes
Nov 18, 2024
…ter without restricting nic speed detection (apache#21409) (cherry picked from commit 789d284)
nikhil-ctds
force-pushed
the
nics-fix
branch
from
914e937 to
daf73d2
Compare
nikhil-ctds
force-pushed
the
nics-fix
branch
from
d4daa29 to
0c07ca2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Broker service unavailability during upgrades in heterogeneous hardware clusters occurs because the PR fails to account for varying NIC speeds across different VM types. Consequently, broker startups are failing on all VMs, and the workaround using
loadBalancerOverrideBrokerNicSpeedGbpsis ineffective due to the inability to manage diverse configurations for each broker.Additionally, the changes were removed from
ExtensibleLoadManagerTest.javaas the test was failing. Here is the commit that removed the changes: (0c07ca2).Verifying this change
Documentation
Need to update docs?
doc-requiredno-need-docdoc